454875 - After selecting a tab, slide tab strip away

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Christian Sejersen]

When you have chosen to switch to a tab from the tab strip, slide the strip away and show the chosen tab without any controls visible.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Refactors the "show" code a bit and hides sidebars when needed

This patch refactors the code that "shows" controls. In doing so, we now hide the tab area after selecting a tab and after making a new tab.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 338209 [details] [diff] [review]
Refactors the "show" code a bit and hides sidebars when needed

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+  closeTab : function(aTab) {
>+    alert("remove");
>+    Browser.content.removeTab(aTab);

you're not going to land this, presumably :)

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> (From update of attachment 338209 [details] [diff] [review])
> >diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
> 
> >+  closeTab : function(aTab) {
> >+    alert("remove");
> >+    Browser.content.removeTab(aTab);
> 
> you're not going to land this, presumably :)

Ugh, did not land that.

http://hg.mozilla.org/mobile-browser/rev/92f0216f9c7b

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

lol, now we changed this to keep the tab strip in focus for beta3