Closed Bug 454875 Opened 11 years ago Closed 11 years ago

After selecting a tab, slide tab strip away

Categories

(Firefox for Android Graveyard :: General, defect, P2)

Other
Maemo
defect

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0a1

People

(Reporter: christian.bugzilla, Assigned: mfinkle)

Details

(Whiteboard: UI)

Attachments

(1 file)

When you have chosen to switch to a tab from the tab strip, slide the strip away and show the chosen tab without any controls visible.
Flags: wanted-fennec1.0+
Whiteboard: UI
Priority: -- → P2
Assignee: madhava → mark.finkle
This patch refactors the code that "shows" controls. In doing so, we now hide the tab area after selecting a tab and after making a new tab.
Attachment #338209 - Flags: review?(gavin.sharp)
Attachment #338209 - Flags: review?(gavin.sharp) → review+
Comment on attachment 338209 [details] [diff] [review]
Refactors the "show" code a bit and hides sidebars when needed

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>+  closeTab : function(aTab) {
>+    alert("remove");
>+    Browser.content.removeTab(aTab);

you're not going to land this, presumably :)
(In reply to comment #2)
> (From update of attachment 338209 [details] [diff] [review])
> >diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
> 
> >+  closeTab : function(aTab) {
> >+    alert("remove");
> >+    Browser.content.removeTab(aTab);
> 
> you're not going to land this, presumably :)

Ugh, did not land that.

http://hg.mozilla.org/mobile-browser/rev/92f0216f9c7b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
lol, now we changed this to keep the tab strip in focus for beta3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.