454965 - Inconsistent shortcut keys for "new tab/new window"

Status: REOPENED

(Firefox :: Bookmarks & History, defect, P5)

Description

[arnoud]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1

The right-mouse button menu for hyperlinks has shortcuts for "Open link in new tab/new window" which are assigned to W and T, respectively. However, in the Bookmarks menu those same menu items are assigned shortcut keys N and W, respectively. This is inconsistent.

Suggested fix: use N and W in the right-mouse button menu.

Reproducible: Always

Steps to Reproduce:
1. Right-mouseclick on a hyperlink
2. Right-mouseclick on a bookmark in the Bookmarks menu or toolbar
3. Compare shortcut keys for "open link in new window" and "open link in new tab"
Actual Results:  
see above

Expected Results:  
see above

see above

Comment 1

[John Hansen]

I'll second this. This has been a very irritating change from 2.x to 3.x (currently running a nightly) and I was wondering if there was any justification to such an arbitrary shortcut key change.

Also, when in the Bookmarks menu, I have noticed that pressing T to open a new tab when right-clicking on a bookmark actually *deletes* the bookmark, which has caused me no small degree of frustration.

Will try latest nightly and re-check, but since nobody else seems to have noticed I'm not sure there's any difference.

Comment 2

[John Hansen]

Confirmed that right-clicking on a bookmark and pressing T actually deletes the bookmark in latest nightly.

Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080916043910 Minefield/3.1b1pre

I can probably give a patch a shot, but any idea which file I might want to start with in the source tree?

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #1)
> Also, when in the Bookmarks menu, I have noticed that pressing T to open a new
> tab when right-clicking on a bookmark actually *deletes* the bookmark

It cuts it, as T is assigned to "Cut".

Comment 4

[John Hansen]

D'oh. Missed that.

This makes life interesting, since pretty much every other program out there uses T as a menu shortcut for cut. I suppose if all the menus, including the File menu, are changed to N and W to match, then it makes a little more sense.

Of course, then it wouldn't quite match with the usage of Ctrl+T, but...

Comment 6

[slisochies]

Yup, this bug is extremely annoying. As a laptop user I regularly use keyboard shortcuts. It is very irritating that whenever I wish to open a link in an new tab I use Ctrl-T, however when I wish to open a bookmark (usually from an RSS feed) I have to switch to Ctrl-W.

I would really appreciate it if this is fixed for the next release. I doubt it would involve much effort to fix.

Comment 7

[Micah Gersten]

Ubuntu Bug:
https://bugs.launchpad.net/bugs/393791

Comment 8

[Jean-Yves Perrier [:teoli]]

I believe this is a duplicate of bug 301888, isn't it?

Comment 9

[kcarchana77]

I would like to work on this bug. It would be nice if you could assign this bug to me.

Comment 10

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.