454978 - Difficult to "close" strips

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Christian Sejersen]

When trying to "close" a strip (both for tabs and controls) it is very easy to "open" the opposite. E.g. if I swipe right to close the control strip, it very often happens that the tab strip opens. My suggestion that in order for the other strip to be opened while closing another, it should require two swipes: one for closing a swipe (that should never open another), and a second for opening the other.

Comment 1

[Madhava Enros [:madhava]]

I think this (requiring two swipes) is one of two things we can try to make this better.  The other is having some more elastic resistance to the opening a control strip (which is just another way of saying moving past the edge of the page).  If one had to move far enough off the page before a control strip would snap into place, returning to the page border otherwise, this problem would probably go away.

Implicit in this is the idea is that, once your finger is off the screen, a control strip must be entirely on or entirely off the screen -- i.e. no permanently half-revealed control strips.

If that still doesn't resolve the problem then I think it's worth trying what Christian suggests here -- that a single swipe cannot take you from off the page in one direction to off the page in the other.

Comment 2

[Christian Sejersen]

I agree, it should not be possible to have strips partially visible on the screen.

Comment 3

[Daniel Brooks [:db48x]]

Or perhaps if one is open, a longer swipe in the other direction is needed before the other will open. A normal-sized swipe would then close the open one without also opening the other.

Comment 5

[Madhava Enros [:madhava]]

re: comment 3 -- yes, we can try that out, too.  First, I'd just like to get to the point where they're snapping into place.  The longer vs. shorter swipes may just naturally fall out of how far you have to go from one side to reveal the other side, but, if not, we can tune the experience that way.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: Adds snapping behavior to sidebars

This patch adds code to handle situations where the sidebars are partially visible. If 30% or more of the sidebar is visible, we snap it completely into view.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

... else we snap the sidebar out of view

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/034b846de83a

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

verified in beta3