454983 - Error when editing repeating event with exceptions (NS_ERROR_INVALID_POINTER in calRecurrenceInfo.js)

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18pre) Gecko/2008091120 Sunbird/0.9

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Create a new repeating event (e.g. Repeat: Weekly) and save
3. Select one occurrence of the repeating event and delete just this occurrence
4. Select another occurrence and choose to edit all occurrences
5. From the Repeat drop down menu choose Custom... to set an end date

Actual Results:
Edit Recurrence dialog opens but is incorrectly set to Daily pattern and the preview is empty. Error Console shows:

Error: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [calIDateTime.addDuration]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: ffile:///D:/sunbird/js/calRecurrenceInfo.js :: cRI_onStartDateChange :: line 865"  data: no]
Source File: ffile:///D:/sunbird/js/calRecurrenceInfo.js
Line: 865

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [calIDateTime.addDuration]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: ffile:///D:/sunbird/js/calRecurrenceInfo.js :: cRI_onStartDateChange :: line 865"  data: no]

Expected Results:
Repeating event with exceptions can be edited.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

Besides this bug it fixes
- a leftover origRdates
- adopts UNTIL datetimes when moving series

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 338304 [details] [diff] [review]
fix - v1

Looks good, r=philipp

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH and SUNBIRD_0_9_BRANCH

-> FIXED

Comment 4

[Stefan Sitter [:ssitter]]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18pre) Gecko/2008091218 Sunbird/0.9.