454998 - [CalDAV] free/busy lookups don't work

Status: RESOLVED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[Brian]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: 2008091118

As you all know, bug 452610 made CalDAV-sched an user settable option, disabled by default.  The problem is that means free/busy lookups are now disabled by default.  This results in a loss of critical functionality.

If we  leave the default setting, we no longer get free/busy lookups.  This is something that worked in the previous release (0.8)

OTOH, we get free/busy lookups if we enable the caldav scheduling option, but we lose the ability to send invitations.  This is because the e-mail invitation is no longer generated, and the caldav-sched invitation is not functional for our server (Bedework 3.4.1.1).

I consider this to be a regression, since a critical feature (free/busy lookups) is no longer available.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Daniel Boelzle [:dbo]]

Needs to be resolved.
There seems to be something odd: I see free-busy requests being logged, but the freebusy pane isn't reflecting the results.

Comment 2

[Bruno Browning]

I think we also have a Sunbird/Lightning distinction here. On the last build I checked I was unable to get fb to work in Sb even with the pref set to true. Possibly a separate bug, but if so a serious enough a regression that I would consider it a blocker.

Comment 3

[Brian]

I just tried this again, with scheduling disabled, and I see the following error in the error console (with debugging enabled):

calGoogleRequest: Requesting GET https://www.google.com/calendar/feeds/bleathem%40triumf.ca/private/free-busy?ctz=America%2FVancouver&max-results=2147483647&singleevents=true&start-min=2008-09-15T00%3A00%3A00-07%3A00&start-max=2008-10-01T00%3A00%3A00-07%3A00

However, I was creating an event in my Bedework calendar, which is on the server cal.triumf.ca.  So it seems to be directing the response to the wrong server.

If I change the selected calendar in the new event dialog to use my google calendar, then go back to inviting attendees, I see:
calGoogleRequest: Requesting GET https://www.google.com/calendar/feeds/bleathem%40gmail.com/private/free-busy?ctz=America%2FVancouver&max-results=2147483647&singleevents=true&start-min=2008-09-15T00%3A00%3A00-07%3A00&start-max=2008-10-01T00%3A00%3A00-07%3A00

which does correctly show my free/busy (for my gmail account)

If this is not related to this bug, I can file a new bug report.

Brian

Comment 4

[Daniel Boelzle [:dbo]]

Attachment: fix - v1

Cause: We didn't query for the principal ns and outbox etc in case scheduling has been disabled. Moreover this patch fixes some error conditions on fb queries, firing the listener.

Comment 5

[Bruno Browning]

Comment on attachment 338454 [details] [diff] [review]
fix - v1

This does get getFreeBusyIntervals() called. But the added onResult calls cause the freebusy UI to go from Unknown to Free beginning with the first character typed rather than remaining Unknown until some real fb data comes back from the server. I think you need to onResult(null, null) there instead of returning an empty array.
r=browning with that

Comment 6

[Daniel Boelzle [:dbo]]

Right, looks better, I've changed that.

Checked in on HEAD, MOZILLA_1_8_BRANCH and SUNBIRD_0_9_BRANCH => FIXED.

Comment 7

[Brian]

After you committed this change, I tested with the latest nightly, and it indeed worked.  Now free/busy lookups are again no longer working (I'm using the latest nightly, build 2008091522)

With debugging on, in the error console, I'm still seeing the error:
calGoogleRequest: Requesting GET https://www.google.com/calendar/feeds/glenn%40triumf.ca/private/free-busy?ctz=America%2FVancouver&max-results=2147483647&singleevents=true&start-min=2008-09-18T00%3A00%3A00-07%3A00&start-max=2008-10-04T00%3A00%3A00-07%3A00

This occurs when creating an event in our Bedework calendar, and inviting one of our Bedework users.  However the free/busy request seems to be going to google, (my google calendar is my default calendar).

Comment 8

[Daniel Boelzle [:dbo]]

(In reply to comment #7)
> After you committed this change, I tested with the latest nightly, and it
> indeed worked.  Now free/busy lookups are again no longer working (I'm using
> the latest nightly, build 2008091522)
> 
> With debugging on, in the error console, I'm still seeing the error:
> calGoogleRequest: Requesting GET
> https://www.google.com/calendar/feeds/glenn%40triumf.ca/private/free-busy?ctz=America%2FVancouver&max-results=2147483647&singleevents=true&start-min=2008-09-18T00%3A00%3A00-07%3A00&start-max=2008-10-04T00%3A00%3A00-07%3A00
> 
> This occurs when creating an event in our Bedework calendar, and inviting one
> of our Bedework users.  However the free/busy request seems to be going to
> google, (my google calendar is my default calendar).

It's by intent that all registered free-busy providers are queried for free-busy information, even the google calendar. Since your google calendar seems to cause trouble doing the query: If you disable it (via calendar properties dialog), does free-busy properly work on the Bedework calendar?

Comment 9

[Brian]

Disabling my google calendar(s) fixes free/busy on the Bedework calendar.  Howerver, it continues to work after I re-enable the google calendars.