455035 - Crash shutting down in cookie code

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Boris Zbarsky [:bzbarsky]]

###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->().: 'mRawPtr != 0', file ../../../dist/include/xpcom/nsCOMPtr.h, line 811

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0x00000000
0x00d27b0c in nsCookieService::Observe (this=0xc8b1f10, aSubject=0xc678360, aTopic=0x12e50b "profile-before-change", aData=0x13fb40) at /Users/bzbarsky/mozilla/debug/mozilla/netwerk/cookie/src/nsCookieService.cpp:629
629         mDBConn->Close();

For some reason we failed to open the database during startup, but we're blindly trying to close it anyway.  This should have a null-check, methinks.

Comment 1

[Patrick McManus [:mcmanus]]

see https://bugzilla.mozilla.org/show_bug.cgi?id=449986

Comment 2

[[e-mail]]

i don't have a tree to patch this atm, but if someone can do the honors i'll r+.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bah

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 338416 [details] [diff] [review]
Bah

maybe you should move the if for shutdown-cleanse into this one

Comment 5

[[e-mail]]

Comment on attachment 338416 [details] [diff] [review]
Bah

thanks bz, sorry you had to do this. i owe you one :(

r=dwitte

Comment 6

[timeless]

fixed in changeset 0e9b30800119

Comment 7

[Boris Zbarsky [:bzbarsky]]

Thanks for checking it in, but please use -u next time?  ;)