Closed
Bug 455043
Opened 16 years ago
Closed 16 years ago
remove HTML 3 quirks mode
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: crazy-daniel, Assigned: mrbkap)
References
Details
Attachments
(1 file)
23.38 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Bug 30378 added code hooks to enable the parser not to interfer tbody elements when HTML 3 documents are processed. This was never enabled and would actually cause problems if it were. I suggest the removal of that code. As far as I can tell, these files need to be cleaned up: http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsParser.cpp * Line 861-864 and line 660 can be removed. * Replace "eHTML3_Quirks" with "eHTML_Quirks". * Replace "PubIDInfo::eQuirks3" with "PubIDInfo::eQuirks". http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/CNavDTD.cpp * Lines 3129-3134 and line 39 can be removed http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsHTMLTokenizer.cpp * Line 96 can be removed. Also "eHTML3_Quirks" needs to be replaced by "eHTML_Quirks" in these files: * http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/public/nsIParser.h * http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsViewSourceHTML.cpp * http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsHTMLTokenizer.h * http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/CNavDTD.cpp This is only a small cleanup, but since the code does nothing at all there's no reason to keep it.
Flags: wanted1.9.1?
Comment 1•16 years ago
|
||
Not going to mark this wanted, but assigning to blake who's most likely to work on this.
Assignee: nobody → mrbkap
Flags: wanted1.9.1? → wanted1.9.1+
Assignee | ||
Comment 2•16 years ago
|
||
Attachment #339377 -
Flags: superreview?(jst)
Attachment #339377 -
Flags: review?(jst)
Updated•16 years ago
|
Attachment #339377 -
Flags: superreview?(jst)
Attachment #339377 -
Flags: superreview+
Attachment #339377 -
Flags: review?(jst)
Attachment #339377 -
Flags: review+
Assignee | ||
Comment 4•16 years ago
|
||
Pushed as http://hg.mozilla.org/mozilla-central/rev/eb88f8333eea finally! Thanks for pointing this out Daniel!
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•