remove HTML 3 quirks mode

RESOLVED FIXED

Status

()

Core
HTML: Parser
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Daniel.S, Assigned: mrbkap)

Tracking

Trunk
Points:
---
Bug Flags:
wanted1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Bug 30378 added code hooks to enable the parser not to interfer tbody elements when HTML 3 documents are processed.

This was never enabled and would actually cause problems if it were. I suggest the removal of that code.

As far as I can tell, these files need to be cleaned up:

http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsParser.cpp
* Line 861-864 and line 660 can be removed.
* Replace "eHTML3_Quirks" with "eHTML_Quirks".
* Replace "PubIDInfo::eQuirks3" with "PubIDInfo::eQuirks".

http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/CNavDTD.cpp
* Lines 3129-3134 and line 39 can be removed

http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsHTMLTokenizer.cpp
* Line 96 can be removed.

Also "eHTML3_Quirks" needs to be replaced by "eHTML_Quirks" in these files:
* http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/public/nsIParser.h
* http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsViewSourceHTML.cpp
* http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/nsHTMLTokenizer.h
* http://mxr.mozilla.org/mozilla-central/source/parser/htmlparser/src/CNavDTD.cpp


This is only a small cleanup, but since the code does nothing at all there's no reason to keep it.
Flags: wanted1.9.1?
Not going to mark this wanted, but assigning to blake who's most likely to work on this.
Assignee: nobody → mrbkap
Flags: wanted1.9.1? → wanted1.9.1+
(Assignee)

Comment 2

10 years ago
Created attachment 339377 [details] [diff] [review]
Fix
Attachment #339377 - Flags: superreview?(jst)
Attachment #339377 - Flags: review?(jst)

Updated

10 years ago
Attachment #339377 - Flags: superreview?(jst)
Attachment #339377 - Flags: superreview+
Attachment #339377 - Flags: review?(jst)
Attachment #339377 - Flags: review+
(Reporter)

Comment 3

10 years ago
checkin-needed?
(Assignee)

Comment 4

10 years ago
Pushed as http://hg.mozilla.org/mozilla-central/rev/eb88f8333eea finally!

Thanks for pointing this out Daniel!
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.