455081 - Update reporter to re-implement status page

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Michael Morgan [:morgamic]]

Once the cron job is in place to update a key->value table we need a simple script to pull it out and display it in the php reporter.

Les - could you work with Ted to come up with:
1) a simple way to store this info
2) a simple MVC for it in the reporter

Comment 1

[Austin King [:ozten]]

Attachment: Screenshot for patch1

Comment 2

[Michael Morgan [:morgamic]]

Woo!  That looks awesome, Austin.

Comment 3

[Austin King [:ozten]]

Attachment: Patch depends on new table server_status populated by cron job

This patch has MVC for updates status screen. Attached is a screenshot.

We graph 4 stats (# of waiting jobs, # processors, avg process in sec, avg job wait) and show 2 more stats (date job recently completed, date of oldest job in queue) in the table of data.

The server has three states happy, grumpy, and deathly

Questions I have:
1) How frequent should server status be (5 minutes)?
2) How much history should we show (1 hour)?
3) What makes for a happy server? Which criteria and what are the thresholds. Currently this is hardcoded to happy


TODO:
* I need to add where clause to limit server_status table query ( once I know answers to 1 and 2 above )
* Add a link to status page to the header ( site wide navigation )

Not directly related, but in patch for code review:
- pulled platform ("Windows" "windows" "#3Ef") info out of model and into a config file

Comment 4

[Austin King [:ozten]]

Comment on attachment 344122 [details] [diff] [review]
Patch depends on new table server_status populated by cron job

Adding morgamic to code review

Comment 5

[Austin King [:ozten]]

Attachment: native svn diff for earlier patch

Reuploading patch. This time as the native svn diff.

Comment 6

[Austin King [:ozten]]

Attachment: Added missing model and config to patch

Comment 7

[Austin King [:ozten]]

Comment on attachment 344130 [details] [diff] [review]
Added missing model and config to patch

Adding morgamic as reviewer

Comment 8

[Les Orchard [:lorchard]]

Comment on attachment 344130 [details] [diff] [review]
Added missing model and config to patch

Looks good to me, and seems to work fine on my install.

I think morgamic mentioned it'd be nice to have a table of contents or something at the top of the page to jump down to individual graphs.

Also, might be good to file follow-up bugs to get a) the crontab script together to populate the server_status table, if not already done, and b) to finish the TODO for the calculation of the happy / grumpy / deathly status.

Oh, and also also:  Would be useful to include SQL to create the server_status table in the patch, or better yet in SVN once this is checked in.  Check out the sql/ directory one level up from the webapp-php directory.

Comment 9

[Austin King [:ozten]]

Note: python and db feedback from les Thanks, Bug 455080 has those details, yes did check in DDL SQL.

Check in r634. Other minor fixes in patch:
Changed report/do_list OS crash graph to be bar charts of total # of crashes by
OS.
Make OS names and colors a config instead of model code.

Comment 10

[Austin King [:ozten]]

Marking fixed.

Comment 11

[Michael Morgan [:morgamic]]

Attachment: alternate version of status page w/ graph selector

Austin/Les - what do you think of this as an alternative to having the table of contents?

Comment 12

[Michael Morgan [:morgamic]]

Les - I noticed we picked 4.0.1 strict but it did not validate and we were self-terminating elements all over so I flipped it.  Mostly I like making people mad by serving xhtml as text/html.

Comment 13

[Austin King [:ozten]]

Comment on attachment 344442 [details] [diff] [review]
alternate version of status page w/ graph selector

I think the patch improves the page. I don't see any issues with the code. My one concern is putting related graphs behind a a dropdown removes the ability to compare them side by side.