Add test ssl server certificate re-generation to tools phase in build/pgo

RESOLVED FIXED

Status

Testing
Mochitest
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
There is new target 'tools' that runs after export and libs. Use it could make update of mochitest ssl certificates more easy because now modification to the list of hosts and cert bindings made in build/pgo needs, to be reflected, build of testing/mochitest (quit illogical when build/pgo is not a platform just for mochitest, but there were no better way).
(Assignee)

Comment 1

9 years ago
Created attachment 338636 [details] [diff] [review]
Possible patch, v1

This fix runs tools phase on all tiers after all tiers passed export,libs,export,libs.. phases when build is performed by 'make -f client.mk build'. This allows move of ssl mochitest cert generation to tools phase in build/pgo where it belongs but also has effect like a build of XPCOM tests that would not normally be built as part of the full build.
Attachment #338636 - Flags: review?(benjamin)
(Assignee)

Comment 2

9 years ago
Actually, certificate regeneration must be made as part of build/pgo module and of testing/mochitest as well.

build/pgo becuase xpc-shell tests use the server as well and it doesn't make sense to force people wanting to work just with xpc-shell tests to rebuild mochitest to reflect changes just in build/pgo/server-locations.txt file.

testing/mochitest because mochitest copies the server-locations.txt file to _test/testing/mochitest and its change is not reflected by only build of build/pgo module.

So, I would suggest following: add certificate generation to build/pgo/Makefile during tools phase and leave everything else unchanged. 

This works in all cases: complete rebuild, reflect changes for xpc-shell tests, reflect changes for mochitest. Certificate is generated during full build as part of mochitest build (as is now), during manual rebuild of build/pgo (now tools phase is invoked) and during mochitest rebuild (as it is now).

Do you agree?
Summary: Should test ssl certificates be generated during tools phase in build/pgo? → Add test ssl server certificate re-generation to tools phase in build/pgo
Sounds reasonable.

Updated

9 years ago
Attachment #338636 - Flags: review?(benjamin) → review?(ted.mielczarek)
(Assignee)

Comment 4

9 years ago
Created attachment 339279 [details] [diff] [review]
v2
[Checkin: Comment 6]

Actually, this patch is correct according to the last two comments.
Attachment #338636 - Attachment is obsolete: true
Attachment #339279 - Flags: review?(ted.mielczarek)
Attachment #338636 - Flags: review?(ted.mielczarek)
(In reply to comment #2)
> build/pgo becuase xpc-shell tests use the server as well and it doesn't make
> sense to force people wanting to work just with xpc-shell tests to rebuild
> mochitest to reflect changes just in build/pgo/server-locations.txt file.

Actually, xpcshell tests can't use ssltunnel currently. They can use the httpd.js server, but they have to start it manually.

The more I think about this, the more I want to rearrange some parts of the source to make things clearer.
Attachment #339279 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Comment on attachment 339279 [details] [diff] [review]
v2
[Checkin: Comment 6]

http://hg.mozilla.org/mozilla-central/rev/7265ecfe2a0e
Attachment #339279 - Attachment description: v2 → v2 [Checkin: Comment 6]
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.