455236 - [te] To make Telugu text appear same on windows and linux, zwnj at the end of consonant ending conjucts is to be removed

Status: RESOLVED FIXED

(Mozilla Localizations :: te / Telugu, defect)

Description

[arjuna rao chavala]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008071615 Fedora/3.0.1-1.fc9 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008071615 Fedora/3.0.1-1.fc9 Firefox/3.0.1

This fixes the translation text to make the rendering same on linux and windows, by transforming foreign word with consonant ending to vowel ending. Ex: Firefox is changed in telugu equivalent of Firefoxu.

Reproducible: Always

Steps to Reproduce:
1.Nightly builds of te build 5 (3.0.2)
2.
3.
Actual Results:  
In linux rendering OK, but on windows, the consonants split making it awkward to read.

Expected Results:  
Uniform rendering on linux/windows.

foreign words are made into vowel endings

Comment 1

[arjuna rao chavala]

Attachment: te directory cvs diff

Update for te files to fix the rendering problem

Comment 2

[Samuel Sidler (old account; do not CC)]

This belongs in the localization product.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 338538 [details] [diff] [review]
te directory cvs diff

Visually, this looks like the right thing, but I'd like Krishna to review this patch first.

There's one technical thing I found so far, that's in the contributors, you added the email address with just an opening < without a closing >, I'd like that fixed at least.

Comment 4

[Axel Hecht [:Pike]]

If this patch is correct, this should block de-betaing, IMHO. Nominating by making this block bug fx3-l10n-te.

Comment 5

[Axel Hecht [:Pike]]

Attachment: orig/patched output on all platforms

I did screenshots of one example of the patch on all three platforms. It's the 5th word in robots.errorLongDesc4 in aboutRobots.dtd, పోస్టేరియర్స్‍‌ and పోస్టేరియర్సు ‌.

Does that help?

Comment 6

[arjuna rao chavala]

Attachment: Telugu patch for fixing rendering issue

Updated file to fix the comments with regard to '>' https://bugzilla.mozilla.org/show_bug.cgi?id=455236#c3

Comment 7

[arjuna rao chavala]

Comment on attachment 343817 [details]
Telugu patch for fixing rendering issue

Krishna: As this issue was discussed in our firefox_te mailing list, please approve the same soon

Comment 8

[arjuna rao chavala]

(In reply to comment #5)
> Created an attachment (id=343215) [details]
> orig/patched output on all platforms
> 
> I did screenshots of one example of the patch on all three platforms. It's the
> 5th word in robots.errorLongDesc4 in aboutRobots.dtd, పోస్టేరియర్స్‍‌ and
> పోస్టేరియర్సు ‌.
> 
> Does that help?

Axel: You captured it well. Glad to know that Mac rendering is also fine

Comment 9

[Krishna Babu K]

Hi,

There is an issue with ZWJ (mostly) and ZWNJ among the platforms. So that is giving problem to Telugu text rendering in some cases.

According to this Arjuna has submitted one patch. I gone through the patch.
Here i am confirming that, it would be nice to apply that patch to the current 
translation.

Thanks,
Krishna.

Comment 10

[Krishna Babu K]

Comment on attachment 343817 [details]
Telugu patch for fixing rendering issue

approved

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 343817 [details]
Telugu patch for fixing rendering issue

a=me for landing on cvs trunk. Please land this with a check-in comment that describes the change, references arjuna as author, your review and my approval. Something like "bug 455236, adjust use of zwnj to better render on windows and mac, patch=[e-mail], r=me, a=[e-mail]" would work. "me" in this comment would reference you, as you're the one checking in ;-)

Please add the fixed1.9.0.4 keyword once this landed in CVS, and switch that over to verified1.9.0.4 if the fix got tested and verified on a nightly build from ftp.

Comment 12

[arjuna rao chavala]

Krishna has landed on cvs and hg trunk. The 3.0.3 nightly build has been verified on linux and windows and found to be working fine.

Comment 13

[Axel Hecht [:Pike]]

Marking FIXED, then.

Comment 14

[arjuna rao chavala]

The problem  was traced to an error in the telugu font Lohit-te that was used. With Pothana2000 telugu font, there is no problem. ( https://bugzilla.redhat.com/show_bug.cgi?id=476427 )
Hence the changes because of this bug need to be reversed. A new bug will be  created to track the same.

Comment 15

[arjuna rao chavala]

new bug is 471121

Comment 16

[arjuna rao chavala]

new bug url https://bugzilla.mozilla.org/show_bug.cgi?id=471121