455238 - Extensions manager unit tests fail with --enable-application=xulrunner

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Hommey [:glandium]]

At least some of these are due to the fact that the extension manager requires branding (brandShortName).
Here are the logs:
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug257155.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug299716_2.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug299716.js: FAIL
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug299716.js.log:
>>>>>>>
*** test pending


*** INSTALLING NEW ITEMS

*** Phone Home Listener: Update Started
*** Datasource: Update Started
*** Phone Home Listener: Update For [e-mail]">[e-mail] started
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///home/mh/git/xulrunner/dist.xulrunner/bin/components/nsExtensionManager.js :: anonymous :: line 251"  data: no]
*** FAIL ***

<<<<<<<
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug335238.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug356370.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug378216.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug384052.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug391899.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug393285.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug394300.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug394717.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug396129.js: FAIL
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug396129.js.log:
>>>>>>>
*** test pending
onInstallStarted
onInstallEnded
onInstallsCompleted
onInstallStarted
onInstallEnded
onInstallsCompleted
onInstallStarted
onInstallEnded
onInstallsCompleted
onInstallStarted
onInstallEnded
onInstallsCompleted
*** Datasource: Update Started
*** Datasource: Addon Update Started: [e-mail]">[e-mail]
*** RDFItemUpdater:checkForUpdates sending a request to server for: http://localhost:4444/data/test_bug396129.rdf, item = ({id:"[e-mail]">[e-mail]", version:"1", installLocationKey:"app-profile", minAppVersion:"1", maxAppVersion:"2", name:"Bug 396129 Test A", xpiURL:"", xpiHash:"", iconURL:"chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png", updateRDF:"http://localhost:4444/data/test_bug396129.rdf", updateKey:"", type:2, targetAppID:"[e-mail]"})
*** test pending
*** test finished
*** running event loop
*** RDFItemUpdater:onDatasourceLoaded: Found a newer version of this item:
({id:"[e-mail]">[e-mail]", version:"2", installLocationKey:"app-profile", minAppVersion:"1", maxAppVersion:"2", name:"Bug 396129 Test A", xpiURL:"http://localhost:4444/addons/test_bug396129_a_2.xpi", xpiHash:null, iconURL:"", updateRDF:"", updateKey:"", type:2, targetAppID:"[e-mail]"})
onDownloadStarted
*** Datasource: Addon Update Ended: [e-mail]">[e-mail], status: 1
*** Datasource: Update Ended
onDownloadEnded
onInstallStarted
onCompatibilityCheckStarted
*** Phone Home Listener: Update Started
*** Datasource: Update Started
*** Phone Home Listener: Update For [e-mail]">[e-mail] started
*** exiting
*** CHECK FAILED: onCompatibilityCheckEnded == onInstallEnded
JS frame :: ../../../../tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
JS frame :: ../../../../tools/test-harness/xpcshell-simple/head.js :: do_check_eq :: line 114
JS frame :: ../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug396129.js :: anonymous :: line 157
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
JS frame :: file:///home/mh/git/xulrunner/dist.xulrunner/bin/components/nsExtensionManager.js :: anonymous :: line 5677
JS frame :: file:///home/mh/git/xulrunner/dist.xulrunner/bin/components/nsExtensionManager.js :: anonymous :: line 5855
*** FAIL ***

<<<<<<<
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug397778.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug404024.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug406118.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug417606.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug421396.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug424107.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug424262.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug425657.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js: FAIL
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js.log:
>>>>>>>
*** test pending
*** test pending
Installing add-on test_bug428341_1
Seen onInstallStarted for add-on test_bug428341_1
*** The Install Manifest supplied by this item is not well-formed. Installation will not proceed.
Seen onInstallEnded for add-on test_bug428341_1
Seen onInstallsCompleted for add-on test_bug428341_1
Installing add-on test_bug428341_2
Seen onInstallStarted for add-on test_bug428341_2
*** exiting
*** CHECK FAILED: Exception installing add-on test_bug428341_2 [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///home/mh/git/xulrunner/dist.xulrunner/bin/components/nsExtensionManager.js :: anonymous :: line 251"  data: no]
JS frame :: ../../../../tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
JS frame :: ../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js :: installNextAddon :: line 246
JS frame :: ../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js :: anonymous :: line 225
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
JS frame :: file:///home/mh/git/xulrunner/dist.xulrunner/bin/components/nsExtensionManager.js :: anonymous :: line 4143
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
JS frame :: ../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js :: installNextAddon :: line 243
JS frame :: ../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js :: run_test :: line 257
JS frame :: ../../../../tools/test-harness/xpcshell-simple/tail.js :: _execute_test :: line 41
JS frame :: ../../../../tools/test-harness/xpcshell-simple/execute_test.js :: <TOP_LEVEL> :: line 38
*** exiting
*** CHECK FAILED: Exception installing add-on test_bug428341_2 [Exception... "'Abort' when calling method: [nsIAddonInstallListener::onInstallsCompleted]"  nsresult: "0x80004004 (NS_ERROR_ABORT)"  location: "JS frame :: file:///home/mh/git/xulrunner/dist.xulrunner/bin/components/nsExtensionManager.js :: anonymous :: line 4143"  data: no]
JS frame :: ../../../../tools/test-harness/xpcshell-simple/head.js :: do_throw :: line 99
JS frame :: ../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js :: installNextAddon :: line 246
JS frame :: ../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug428341.js :: run_test :: line 257
JS frame :: ../../../../tools/test-harness/xpcshell-simple/tail.js :: _execute_test :: line 41
JS frame :: ../../../../tools/test-harness/xpcshell-simple/execute_test.js :: <TOP_LEVEL> :: line 38
2147500036
*** FAIL ***

<<<<<<<
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug430120.js: PASS
../../../../_tests/xpcshell-simple/test_extensionmanager/unit/test_bug436207.js: PASS
make[3]: *** [check] Error 1

Comment 1

[Dave Townsend [:mossop]]

The unit tests will require the application to have branding defined same as the use of the extension manager in an application.

Comment 2

[Mike Hommey [:glandium]]

Are you saying you want to break the test suite for xulrunner builds on purpose ?

Comment 3

[Dave Townsend [:mossop]]

I'm saying that we can't ask that the extension manager unit tests work in an environment where the extension manager cannot work.

Comment 4

[Mike Hommey [:glandium]]

Well then maybe it should be reassigned to xulrunner to have it run the EM test suite with a dummy application ?

Comment 5

[Dave Townsend [:mossop]]

Chances are that would be pretty hard to do for this case, bug bug 360294 and bug 448069 are along those lines.