Closed Bug 455262 Opened 16 years ago Closed 16 years ago

Use PROPFIND instead of REPORT in CalDAV refresh()es

Categories

(Calendar :: Provider: CalDAV, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: browning, Assigned: browning)

References

Details

Attachments

(1 file, 2 obsolete files)

It really does not make sense to use REPORT in getUpdatedItems() any more since we're querying everything in the calendar collection. PROPFIND lets us do this in a single query instead of two, should avoid issues like the current egroupware one where the server responds badly to a VTODO REPORT, and should fix a current problem we have wrt caldav-sched and Zimbra, see http://bugzilla.zimbra.com/show_bug.cgi?id=31168

Tested against: Apple Bedework DAViCal Kerio Oracle Scalix SOGo Zimbra. Patch includes a workaround for a Scalix bug where they return the wrong content-type on .ics files in the calendar collection. I've contacted a Scalix developer about it.

Probably best to do this shortly after 0.9; I'll debitrot and request review then.
I've tested this both cached and uncached on:

eGroupware 1.6pre1
zimbra (whatever is running on mail-test.mome...)
bedework 3.4.1.1
Google CalDAV
Apple (whatever is running on zathras)

and it seems to work fine.
This slightly modified version of the patch speeds up deleting items that have been deleted on the server a bit. Tell me what you think.
Attachment #338569 - Attachment is obsolete: true
Attached patch debitrotted patch β€” β€” Splinter Review
debitrotted patch; requesting dbo review since both Philipp and I wrote parts of this.
Attachment #338600 - Attachment is obsolete: true
Attachment #340682 - Flags: review?(daniel.boelzle)
Comment on attachment 340682 [details] [diff] [review]
debitrotted patch

r=dbo
Attachment #340682 - Flags: review?(daniel.boelzle) → review+
setting checkin-needed as my hg push access is not yet sorted out.
Whiteboard: checkin-needed
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/71e7cad5c95a>

-> FIXED
Assignee: nobody → browning
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
Target Milestone: --- → 1.0
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.