455278 - chrome mochitest redirect fails in fennec

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

error is:
Error: win.getWebNavigation is not a function
Source File: http://localhost:8888/redirect.js
Line: 51


the js that is failing is:
  var windowMediator = Cc['@mozilla.org/appshell/window-mediator;1'].
  getService(Ci.nsIWindowMediator);
  var win = windowMediator.getMostRecentWindow("navigator:browser");
  win.getWebNavigation().loadURI(aURL + location.search,
                                 null, null, null, null);

Comment 1

[:Gavin Sharp [email: [e-mail]]]

The easy fix would be to add the getWebNavigation() helper to fennec chrome (we'll probably end up doing that anyways for Firefox extension compat), but perhaps we should fix that mochitest code to use something more generic. I think the following would work:

let webNav = window.QueryInterface(Ci.nsIInterfaceRequestor)
                   .getInterface(Ci.nsIWebNavigation)
                   .QueryInterface(Ci.nsIDocShellTreeItem)
                   .treeOwner.primaryContentShell
                   .QueryInterface(Ci.nsIWebNavigation);

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: gavin's code as a patch

for some reason using let doesn't work.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 338635 [details] [diff] [review]
gavin's code as a patch

Shouldn't that be |win| instead of |window|?  Or do you really want to run it againstd the current window as opposed to the most recent navigator window?

let probably didn't work because this stuff is not being loaded right; that's worth filing a bug on.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Yeah, it should be win.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Actually, this file is loaded in the content docshell anyways, so we can just use window.QueryInterface(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIWebNavigation) directly. Or maybe even just set document.location? I guess that might run into security checks.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I'll add this comment:
  // Can't just set window.location because of security restrictions
  // that don't care about our UniversalXPConnectness

Comment 8

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/5486e202bbc6