455287 - Drag and drop to Add-ons window broken

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Mark Banner (:standard8)]

In Thunderbird version: 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080914025345 Shredder/3.0b1pre

I drag an add-on link from Firefox to Thunderbird's add-on window, and nothing happens. This used to install the add-on into Thunderbird without me having to download it separately.

In the error console I get:

Error: transferData.first is null
Source File: chrome://global/content/nsDragAndDrop.js
Line: 457

I suspect this is a regression from bug 356295.

Comment 1

[Neil Deakin]

This works in Firefox, and it should be the same addons manager code, no?

The link is being dragged properly? Do you have a way to open an html file in Thunderbird. If so, there's an example at the end of http://developer.mozilla.org/En/DragDrop/Dragging_and_Dropping_Multiple_Items that will dump out what Thundrebird thinks is being dragged.

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> This works in Firefox, and it should be the same addons manager code, no?

As far as I know it is the same code, and yes, doing the same action within Firefox 3.0.1 works for me.

> The link is being dragged properly?

It appears to be. I can drag it into the text box of the error console and got (for example):

https://addons.mozilla.org/en-US/thunderbird/downloads/file/36123/russian_spellchecking_dictionary-0.3.1-fx+tb+sm.xpi

> Do you have a way to open an html file in
> Thunderbird. If so, there's an example at the end of
> http://developer.mozilla.org/En/DragDrop/Dragging_and_Dropping_Multiple_Items
> that will dump out what Thundrebird thinks is being dragged.

For the record, I saved that example as an html, and set the Mail Start Page to a file:// URL pointing at that saved file.

When I tried it I got:

Items: 1
 Item 0:
  text/plain: (string) : <https://addons.mozilla.org/en-US/thunderbird/downloads/file/36123/russian_spellchecking_dictionary-0.3.1-fx+tb+sm.xpi >

Having got those, I tried again, dragging it to the Extensions part of the add-on manager and got the same error as mentioned in comment 0.

Comment 3

[Neil Deakin]

Looks like the data is being dragged only as plaintext but the addons manager only accepts links and files dropped on it.

Comment 4

[Neil Deakin]

Attachment: check urls is IsDataFlavorSupported

This was a bug uncovered by the recent drag and drop api changes. IsDataFlavorSupported only checks certain types, different than the GetData method.

The old code never called IsDataFlavorSupported to check so relied only on GetData.

Mark, can you check if this fixes this bug?

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> Created an attachment (id=338654) [details]
...
> Mark, can you check if this fixes this bug?

I applied the patch to Thunderbird and drag and drop for xpis from Firefox now works correctly. Thanks.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 338654 [details] [diff] [review]
check urls is IsDataFlavorSupported

Can we have a test for this?

Comment 7

[Neil Deakin]

There isn't a means of automatically testing native drag and drop code currently, so this should just be checked in.

Comment 8

[Mark Banner (:standard8)]

Patch checked in, changeset id 19700:66227ade6725.