455339 - Disable word completion widget (software keyboard bar at bottom of screen) for fennec/maemo

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Doug Turner (:dougt)]

when using fennec, sometimes the autocomplete software keyboard widget is displayed.  It doesn't going away until i open and close the keyboard.

Comment 1

[Antonio Gomes (tonikitoo)]

from irc, blassey suggested to disabled that functionality for fennec.

taking...

Comment 2

[Antonio Gomes (tonikitoo)]

blassey, mfinkle, stuart: just to make it done for a2 (and also help with some resize issues), I was thinking of just disable the text-autocomplete feature at all using gconf from debian postinst (during fennec installation)

later, in a followup bug, get it done in a better way (as I explained to mfinkle yesterday: disabling it whenever fennec window get focused).

note that it would affect other applications once it would get disable for the whole system. might be evil ...

thoughs ?

Comment 3

[Antonio Gomes (tonikitoo)]

Attachment: v0.0 - first working version

WIP patch.

the patch basically disables the word-completion widget everytime a top level fennec window gets the focus and reset it to the previous state whenever thistopWindow loses focus. All done via gconf (nsIGContService). 

it is functional already but pretty much WIP so far. If you like the idea, I'd improve it and and make it to work w/ a fennec specific pref in mobile.js (something like platform.work_completion_widget_disabled, true) .

thoughts ?

Comment 4

[Antonio Gomes (tonikitoo)]

Attachment: patch v0.1 - functional patch (but there are open questions)

Patch 0.1 works as following:

whenever fennec/maemo main window gets the focus, it verifies (through GConf) what is the current status of the system property related to the word completion widget. If it is enabled, we disable it (also through gconf). When the main fennec window loses the focus (window is closed, or other app is in use, for example) we restore the previous property value before our change so that that  the widget completion useful for other applications.

Open questions:

1) should we have a preference for enabling/disabling this behaviour, or should it be just the default behaviour (as it) ?

2) right now patch relies on "nsIGConfService" which is not available on maemo platform by default (service gets built and available only if both gconf, gnome-vfs and libgnome are available, but maemo lacks the later - see /toolkit/system/gnome). Should we make GConfService available for maemo in a blocker bug of this one, which is easy, or should we rely on MOZ_ENABLE_GCONF, which is available, and instead of using the nsIGConfService we call gconf API methods straight (e.g. gconf_client_set_bool ) ?

Comment 5

[Antonio Gomes (tonikitoo)]

Attachment: patch v0.2 - ready for review.

same idea as previous patches but 0.2 uses stock gconf (if available) instead of nsGConfService (which does not build for maemo by default - lack of libgnomeui)

Comment 6

[Antonio Gomes (tonikitoo)]

Comment on attachment 364449 [details] [diff] [review]
patch v0.2 - ready for review.

asking stuart to review.

one point: w/ patch 0.2 both virtual and physical keyboards will get the widget-completion disabled.

(note they behaviour differently in which case).

(note2: i will fix the typos in the comments).

Comment 7

[Antonio Gomes (tonikitoo)]

pushed

changeset:   25618:f7f62131998d

thanks stuart

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

this is fixed for all cases except the CTRL+F findbar.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

it seems like with the hard keyboard open on my n810, I get the word complete popping up while adding a new folder in the bookmark manager.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

I am closing this bug and creating a new bug to track the current behavoir

Comment 11

[Aakash Desai [:aakashd]]

Mark, what's the new bug Id? The widget pops up when clicking on search field in google.com/news

Comment 12

[Antonio Gomes (tonikitoo)]

(In reply to comment #11)
> Mark, what's the new bug Id? The widget pops up when clicking on search field
> in google.com/news

bug 518870

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

this is truly an identical bug to bug 518870