Closed
Bug 455357
Opened 16 years ago
Closed 16 years ago
WinCE LibTheora Pre-defined Macro usage in local variable
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wolfe, Assigned: wolfe)
References
Details
(Keywords: mobile)
Attachments
(1 file, 1 obsolete file)
|
4.07 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
LibTheora uses pre-defined macros MOD_MAX and MOD_SHIFT as local variables in the function oc_dering_block().
I renamed these local variables, and followed that change through to places these local variables were used.
Attachment #338682 -
Flags: review?(doug.turner)
|
||
Updated•16 years ago
|
Attachment #338682 -
Flags: review?(doug.turner) → review?(chris.double)
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 338682 [details] [diff] [review]
LibTheora Local Variables Names Changed to stop conflict with WinCE MS-supplied macros.
chris should review this.
|
||
Updated•16 years ago
|
Assignee: nobody → wolfe
|
Assignee | |
Comment 2•16 years ago
|
||
Same as above patch, just adds information into readme_mozilla, and leaves the patch sitting in the media/libtheora directory.
Not for pushing upstream - since this bug will be taken care of by work on Bug 456788 - reduce windows ce shunt impact
Attachment #338682 -
Attachment is obsolete: true
Attachment #340158 -
Flags: review?(chris.double)
Attachment #338682 -
Flags: review?(chris.double)
|
||
Updated•16 years ago
|
Attachment #340158 -
Flags: review?(chris.double) → review+
|
|
||
Comment 3•16 years ago
|
||
813c214faa50
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Component: General → Video/Audio
Product: Fennec → Core
QA Contact: general → video.audio
You need to log in
before you can comment on or make changes to this bug.
Description
•