WinCE LibTheora Pre-defined Macro usage in local variable

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: wolfe, Assigned: wolfe)

Tracking

({mobile})

Trunk
ARM
Windows Mobile 6 Professional
mobile
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 338682 [details] [diff] [review]
LibTheora Local Variables Names Changed to stop conflict with WinCE MS-supplied macros.

LibTheora uses pre-defined macros MOD_MAX and MOD_SHIFT as local variables in the function oc_dering_block().

I renamed these local variables, and followed that change through to places these local variables were used.
Attachment #338682 - Flags: review?(doug.turner)

Updated

10 years ago
Attachment #338682 - Flags: review?(doug.turner) → review?(chris.double)

Comment 1

10 years ago
Comment on attachment 338682 [details] [diff] [review]
LibTheora Local Variables Names Changed to stop conflict with WinCE MS-supplied macros.

chris should review this.

Updated

10 years ago
Blocks: 432792

Updated

10 years ago
Assignee: nobody → wolfe
(Assignee)

Comment 2

10 years ago
Created attachment 340158 [details] [diff] [review]
v.2 patch

Same as above patch, just adds information into readme_mozilla, and leaves the patch sitting in the media/libtheora directory.

Not for pushing upstream - since this bug will be taken care of by work on Bug 456788 - reduce windows ce shunt impact
Attachment #338682 - Attachment is obsolete: true
Attachment #340158 - Flags: review?(chris.double)
Attachment #338682 - Flags: review?(chris.double)

Updated

10 years ago
Attachment #340158 - Flags: review?(chris.double) → review+

Comment 3

10 years ago
813c214faa50
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Component: General → Video/Audio
Product: Fennec → Core
QA Contact: general → video.audio
Keywords: mobile
You need to log in before you can comment on or make changes to this bug.