Closed
Bug 455372
Opened 18 years ago
Closed 18 years ago
WinCE LibVorbis No FPU Support on WinMobile
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wolfe, Assigned: wolfe)
References
Details
(Keywords: mobile)
Attachments
(1 file, 1 obsolete file)
|
1.29 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
Removed attempted use of FPU for WinCE builds, because no WinMobile devices have floating point units.
Attachment #338693 -
Flags: review?(doug.turner)
| Assignee | ||
Updated•18 years ago
|
Attachment #338693 -
Flags: review?(doug.turner) → review?(chris.double)
| Assignee | ||
Comment 1•18 years ago
|
||
Comment on attachment 338693 [details] [diff] [review]
Removed FPU support for WinCE builds
Doug said that chris should be reviewing media/* changes. Sorry for the hassle, doug.
Comment 2•18 years ago
|
||
Comment on attachment 338693 [details] [diff] [review]
Removed FPU support for WinCE builds
Can you add a note to the README_MOZILLA file in the libvorbis directory referencing this bug number so I don't lose the change when I update the source to a new libvorbis version? Thanks.
Attachment #338693 -
Flags: review?(chris.double) → review+
| Assignee | ||
Comment 3•18 years ago
|
||
Chris, I just added a comment into the readme_mozilla file, did the diff, and added the new comment's diff into the previous patch to create this patch.
Attachment #338693 -
Attachment is obsolete: true
Attachment #338894 -
Flags: review?(chris.double)
Updated•18 years ago
|
Attachment #338894 -
Flags: review?(chris.double) → review+
| Assignee | ||
Updated•18 years ago
|
Keywords: checkin-needed
Comment 4•18 years ago
|
||
I couldn't apply the patch to m-c:
{
2 out of 2 hunks FAILED
}
Keywords: checkin-needed
| Assignee | ||
Comment 5•18 years ago
|
||
I just did a hg pull to my mozilla-central, downloaded the attachment 338894 [details] [diff] [review] (from above) to a file named attachment.cgi.txt, and applied it successfully to my mozilla-central using "patch -p 1 < attachment.cgi.txt"
What am I doing differently from what you are doing, so that your application of this patch fails on both hunks of this attachment but works on my machine?
I am asking because I have a lot of patches I am fitting into bugs, and would hate to waste anyones time with the same mistake again and again!
| Assignee | ||
Comment 6•18 years ago
|
||
I just did a hg pull / hg update of my mozilla-central repository, and it appears as if this patch has already landed.
The changes outlined in this patch are inside the mozilla-central source code I just pulled.
I am not sure why that should be the case, though - I certainly did not land these changes.
Comment 7•18 years ago
|
||
i had no problem applying. this does fix the problem as described.
Updated•18 years ago
|
Assignee: nobody → wolfe
Comment 8•18 years ago
|
||
checked in on Tue Sep 23 21:10:58 2008 -0700
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Component: General → Video/Audio
Product: Fennec → Core
QA Contact: general → video.audio
You need to log in
before you can comment on or make changes to this bug.
Description
•