455389 - SVG foreignObjects don't get NS_FRAME_MAY_BE_TRANSFORMED frame bit.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Keith Schwarz [:kschwarz]]

The -moz-transform patch added a frame bit, NS_FRAME_MAY_BE_TRANSFORMED, which determines whether a frame can possibly have a transform on it.  The current implementation only sets this bit if the frame has the -moz-transform property, but it should also be set for SVG foreignObjects or code that checks for transformed frames might not work correctly.

Patch to follow.

Comment 1

[Keith Schwarz [:kschwarz]]

Attachment: Potential Patch #1

Updated the IsTransformed function to allow the caller to bypass the frame bit check.  Now, in nsFrame::Init, we determine whether or not to set the frame bit by calling IsTransformed(PR_FALSE), which should give back whether or not the frame is actually transformed.  Since IsTransformed can be overridden by derived classes, any frame class that might have a transform on it can give their own implementation of IsTransformed and nsFrame::Init should take care of the frame bit.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why don't you just make nsSVGForeignObjectFrame set the bit?

Comment 3

[Keith Schwarz [:kschwarz]]

(In reply to comment #2)
> Why don't you just make nsSVGForeignObjectFrame set the bit?

While I could modify nsSVGForeignObjectFrame to set the bit, I thought that it might be a good idea to unify the code paths for setting the frame bit and checking for transformation, since the two are basically identical.  That way, if we ever introduce more frames that could be transformed, they just need to override IsTransformed and the frame bit will take care of itself.  However, if it's easier to just change nsSVGForeignObjectFrame to set the bit, I can do that instead.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think that's simpler, yeah. Thanks!

Comment 5

[Keith Schwarz [:kschwarz]]

Attachment: Potential Patch #2 [Checkin: Comment 5]

Simple fix - just adds the frame bit in the nsSVGForeignObjectFrame constructor.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 339023 [details] [diff] [review]
Potential Patch #2
[Checkin: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/2ae966a99b0f