455391 - nsCertOverrideService's mSettingsTable wastes memory

Status: RESOLVED WONTFIX

(Core :: Security: PSM, defect)

Description

[Boris Zbarsky [:bzbarsky]]

When we init this table, there is a debug message:

   pldhash: for the table at address 0x6f57ab0, the given entrySize of 76
            definitely favors chaining over double hashing.

The issue is that the nsCertOverride struct is pretty big.  It can by shrunk by 8 bytes by combining the port, boolean, and bits into a single 32-bit value, but that doesn't really solve the problem.  It might be worth it to store a pointer to a nsCertOverride here instead of storing an nsCertOverride directly.

Comment 1

[timeless]

Attachment: proposal

is this roughly what you wanted?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 497776 [details] [diff] [review]
proposal

I didn't want anything; I just reported a bug about an obvious inefficiency.  I have no idea what this code is doing and why....

Comment 3

[Dana Keeler (she/her) [:keeler]]

Users don't have enough certificate overrides to make this much of an issue (telemetry indicates the vast majority of users have <100 overrides).