Closed
Bug 455417
Opened 16 years ago
Closed 16 years ago
Exception provider not threadsafe
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
|
6.79 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
DOM uses nsDOMScriptObjectFactory to act as its nsIExceptionProvider, but nsDOMScriptObjectFactory is not threadsafe and exceptions can be generated on other threads. Patch attached separates the nsIExceptionProvider chunk into a threadsafe object to avoid any performance hit that threadsafe refcounting may deliver.
Attachment #338756 -
Flags: superreview?(jst)
Attachment #338756 -
Flags: review?(jst)
|
||
Updated•16 years ago
|
Attachment #338756 -
Flags: superreview?(jst)
Attachment #338756 -
Flags: superreview+
Attachment #338756 -
Flags: review?(jst)
Attachment #338756 -
Flags: review+
|
Assignee | |
Comment 1•16 years ago
|
||
Pushed faf61801a719.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 2•16 years ago
|
||
I backed this out to see if it was the cause of test failures. It wasn't so I'll reland later today.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 3•16 years ago
|
||
Relanded.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Does this still need to be threadsafe now that workers don't use XPConnect?
|
|
Assignee | |
Comment 5•13 years ago
|
||
I think this predates workers and was done for random JS running on multiple threads. That was possible back in 2008.
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•