Closed Bug 455445 Opened 11 years ago Closed 11 years ago

-moz-transform skew() function should accept two parameters, and second should default to zero

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: dbaron, Assigned: kschwarz)

References

Details

Attachments

(1 file)

According to http://webkit.org/specs/CSSVisualEffects/CSSTransforms.html#transform-functions the skew() function can have either one or two parameters, and if it has only one the second defaults to zero.

Right now we allow it to only accept one parameter:
http://hg.mozilla.org/mozilla-central/file/f12cdd3e7f05/layout/style/nsCSSParser.cpp#l6867
and we essentially act as though the second parameter should default to the value of the first:
http://hg.mozilla.org/mozilla-central/file/f12cdd3e7f05/layout/style/nsStyleTransformMatrix.cpp#l428
Parser now accepts 1 or 2 angles.  If second angle isn't provided, it defaults to zero.
Assignee: nobody → keith
Status: NEW → ASSIGNED
Attachment #338819 - Flags: superreview?(dbaron)
Attachment #338819 - Flags: review?(dbaron)
Comment on attachment 338819 [details] [diff] [review]
Potential Patch #1
[Checkin: Comment 3]

r+sr=dbaron
Attachment #338819 - Flags: superreview?(dbaron)
Attachment #338819 - Flags: superreview+
Attachment #338819 - Flags: review?(dbaron)
Attachment #338819 - Flags: review+
Comment on attachment 338819 [details] [diff] [review]
Potential Patch #1
[Checkin: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/d3fdd51e7a74
Attachment #338819 - Attachment description: Potential Patch #1 → Potential Patch #1 [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.