455445 - -moz-transform skew() function should accept two parameters, and second should default to zero

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

According to http://webkit.org/specs/CSSVisualEffects/CSSTransforms.html#transform-functions the skew() function can have either one or two parameters, and if it has only one the second defaults to zero.

Right now we allow it to only accept one parameter:
http://hg.mozilla.org/mozilla-central/file/f12cdd3e7f05/layout/style/nsCSSParser.cpp#l6867
and we essentially act as though the second parameter should default to the value of the first:
http://hg.mozilla.org/mozilla-central/file/f12cdd3e7f05/layout/style/nsStyleTransformMatrix.cpp#l428

Comment 1

[Keith Schwarz [:kschwarz]]

Attachment: Potential Patch #1 [Checkin: Comment 3]

Parser now accepts 1 or 2 angles.  If second angle isn't provided, it defaults to zero.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 338819 [details] [diff] [review]
Potential Patch #1
[Checkin: Comment 3]

r+sr=dbaron

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 338819 [details] [diff] [review]
Potential Patch #1
[Checkin: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/d3fdd51e7a74