Closed Bug 455458 Opened 12 years ago Closed 12 years ago

clean up npupp.h and rename it to npfunctions.h

Categories

(Core :: Plug-ins, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

References

Details

Attachments

(1 file, 1 obsolete file)

We should clean up npupp.h and rename it to npfunctions.h. The cleanup should bring it more in line with webkit's npfunctions.h (their header is better) and the rename means we'll have the same header names.

Part of the cleanup is getting rid of the "shortcut" macros we provide. In most cases they are simply obfuscating and they introduce portability problems.
Attached patch fix v1.0 (obsolete) — Splinter Review
Attachment #338812 - Flags: superreview?(jst)
Attached patch fix v1.1Splinter Review
Attachment #338812 - Attachment is obsolete: true
Attachment #338813 - Flags: superreview?(jst)
Attachment #338812 - Flags: superreview?(jst)
Comment on attachment 338813 [details] [diff] [review]
fix v1.1

r+sr=jst, and please make sure you use hg rename to keep the history here with the renamed file.
Attachment #338813 - Flags: superreview?(jst)
Attachment #338813 - Flags: superreview+
Attachment #338813 - Flags: review+
landed on trunk
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 459429
There are still lots of #include "npupp.h" lines and other references to that file left in the codebase. Were you planning on fixing those in a follow-up bug?
(The bug that wuno just filed is only one instance that happens to hurt OS/2.)
Blocks: 464481
You need to log in before you can comment on or make changes to this bug.