clean up npupp.h and rename it to npfunctions.h

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

113.73 KB, patch
jst
: review+
Details | Diff | Splinter Review
Assignee

Description

11 years ago
We should clean up npupp.h and rename it to npfunctions.h. The cleanup should bring it more in line with webkit's npfunctions.h (their header is better) and the rename means we'll have the same header names.

Part of the cleanup is getting rid of the "shortcut" macros we provide. In most cases they are simply obfuscating and they introduce portability problems.
Assignee

Comment 1

11 years ago
Posted patch fix v1.0 (obsolete) — Splinter Review
Attachment #338812 - Flags: superreview?(jst)
Assignee

Comment 2

11 years ago
Posted patch fix v1.1Splinter Review
Attachment #338812 - Attachment is obsolete: true
Attachment #338813 - Flags: superreview?(jst)
Attachment #338812 - Flags: superreview?(jst)
Comment on attachment 338813 [details] [diff] [review]
fix v1.1

r+sr=jst, and please make sure you use hg rename to keep the history here with the renamed file.
Attachment #338813 - Flags: superreview?(jst)
Attachment #338813 - Flags: superreview+
Attachment #338813 - Flags: review+
Assignee

Comment 4

11 years ago
landed on trunk
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Blocks: 459429

Comment 5

11 years ago
There are still lots of #include "npupp.h" lines and other references to that file left in the codebase. Were you planning on fixing those in a follow-up bug?
(The bug that wuno just filed is only one instance that happens to hurt OS/2.)

Updated

11 years ago
Blocks: 464481
You need to log in before you can comment on or make changes to this bug.