455527 - In some cases Embedding startup crashes if gAppData == null

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Null check

I don't know exact steps to reproduce it, but we have one crash:

#0  0x408bdd58 in nsXREDirProvider::AppendProfilePath (aFile=0x2582f0)
    at mozilla/toolkit/xre/nsXREDirProvider.cpp:1315
#1  0x408bec98 in nsXREDirProvider::GetUserDataDirectory (aFile=0xbeb11438, aLocal=0) at ../../dist/include/xpcom/nsCOMPtr.h:804
#2  0x408bf350 in nsXREDirProvider::GetFile (this=0x418e8, aProperty=0x2582b0 "DefProfRt", aPersistent=0xbeb114c8, aFile=0xbeb114c4)
    at mozilla/toolkit/xre/nsXREDirProvider.h:83
#3  0x4116dc48 in FindProviderFile (aElement=0xbeb1138c, aData=0x41371909) at ../../dist/include/xpcom/nsCOMPtr.h:810
#4  0x4116240c in nsSupportsArray::EnumerateBackwards (this=0x51f38, aFunc=0x4116dbd0 <FindProviderFile>, aData=0xbeb114c0)
    at mozilla/xpcom/ds/nsSupportsArray.cpp:639
#5  0x4116e0c4 in nsDirectoryService::Get (this=0x530a0, prop=0x2582b0 "DefProfRt", uuid=@0x2582d8, result=0xbeb116e0)
    at ../../dist/include/xpcom/nsCOMPtr.h:810
#6  0x411999f4 in NS_InvokeByIndex_P (that=0xbeb1138c, methodIndex=1094129929, paramCount=2147483648, params=0x0)
    at mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_arm.cpp:242
#7  0x408f153c in XPCWrappedNative::CallMethod (ccx=@0xbeb11788, mode=XPCWrappedNative::CALL_METHOD)
    at mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2392
#8  0x408f7c40 in XPC_WN_CallMethod (cx=0xb4fe0, obj=0x0, argc=2147483648, argv=0x408f7c40, vp=0x41412a74)
    at mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1473
#9  0x415209b0 in js_Invoke (cx=0xb4fe0, argc=2, vp=0x256428, flags=3199277160)
    at mozilla/js/src/jsinterp.cpp:1308
#10 0x4150e3f8 in js_Interpret (cx=0xb4fe0)
    at mozilla/js/src/jsinterp.cpp:4976
#11 0x41520ca8 in js_Invoke (cx=0xb4fe0, argc=3, vp=0x288188, flags=3199277608)
---Type <return> to continue, or q <return> to quit---
    at mozilla/js/src/jsinterp.cpp:1326
#12 0x408ecc38 in nsXPCWrappedJSClass::CallMethod (this=0x1bbf20, wrapper=0xbeb11b68, methodIndex=3, info=0x164190, nativeParams=0xbeb11cf8)
    at mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp:1523
#13 0x408e811c in nsXPCWrappedJS::CallMethod (this=0x408e811c, methodIndex=10868, info=0xbeb1138c, params=0xbeb11cf8)
    at mozilla/js/src/xpconnect/src/xpcprivate.h:2545
#14 0x4119a330 in PrepareAndDispatch (self=0x216598, methodIndex=1094129929, args=0x10)
    at mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp:132
#15 0x41199a28 in SharedStub () at ../../dist/include/string/nsTSubstring.h:174

Comment 1

[Oleg Romashin (:romaxa)]

Fixed:

http://hg.mozilla.org/mozilla-central/rev/304bae363bbe