[FIX]Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
11 years ago
4 months ago

People

(Reporter: taras.mozilla, Assigned: bzbarsky)

Tracking

Trunk
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

11 years ago
This way GetNodeInfo would only fail with NS_ERROR_OUT_OF_MEMORY
Actually, I meant that we should stop doing it in the XULPrototypeDocument caller, since we control that.  But looking again, this seems to be the only caller of the qualifiedName version of GetNodeInfo, so we would in fact be able to remove this overload altogether.
Reporter

Comment 2

11 years ago
That makes sense, I'll submit a patch unless you beat me to it
Reporter

Comment 3

11 years ago
i hope this is reasonable
Attachment #338903 - Flags: review?(bzbarsky)
Reporter

Comment 4

11 years ago
forgot the .h change in the above patch, i'll commit that if i get an r+
I was more thinking change the fastload code to store the localName and prefix separately instead of constructing the qualified name on save and having to parse it on restore...
Reporter

Comment 6

11 years ago
ok, in that case i'll let you take care of it
Posted patch Like soSplinter Review
Attachment #338903 - Attachment is obsolete: true
Attachment #340586 - Flags: superreview?(jst)
Attachment #340586 - Flags: review?(jst)
Attachment #338903 - Flags: review?(bzbarsky)
Summary: Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo → [FIX]Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo
Attachment #340586 - Flags: superreview?(jst)
Attachment #340586 - Flags: superreview+
Attachment #340586 - Flags: review?(jst)
Attachment #340586 - Flags: review+
QA Contact: content
Pushed changeset 18e5167ac655.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED

Updated

10 years ago
Component: Content → DOM
QA Contact: content → general
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.