This way GetNodeInfo would only fail with NS_ERROR_OUT_OF_MEMORY
Actually, I meant that we should stop doing it in the XULPrototypeDocument caller, since we control that. But looking again, this seems to be the only caller of the qualifiedName version of GetNodeInfo, so we would in fact be able to remove this overload altogether.
That makes sense, I'll submit a patch unless you beat me to it
i hope this is reasonable
forgot the .h change in the above patch, i'll commit that if i get an r+
I was more thinking change the fastload code to store the localName and prefix separately instead of constructing the qualified name on save and having to parse it on restore...
ok, in that case i'll let you take care of it
Summary: Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo → [FIX]Do not do qualified name stuff in nsNodeInfoManager::GetNodeInfo
Pushed changeset 18e5167ac655.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.