455559 - The requestee field should be narrower

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Frédéric Buclin]

As part of bug 420288, we should limit the width of the requestee field (and why not also limit the length of the requester) to avoid (too much) horizontal scroll.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

I just checked on landfill, and based on 28400 email addresses, the median is around 20 characters, and with most addresses shorter than ~25 characters. With size="20", and considering that many addresses have letters such as "i" or "l" in them, we are able to see up to 20-25 characters at once without problem.

I prefer to have some very long addresses being truncated a bit in the requestee field than to waste whitespace in 90% of cases.

Comment 2

[Frédéric Buclin]

Another welcome side-effect is that it makes the "edit attachment as comment" frame much wider.

Comment 3

[Guy Pyrzak]

Comment on attachment 403359 [details] [diff] [review]
patch, v1

I'd prefer to use CSS to make this change, mostly b/c we want to move towards using CSS for formatting stuff like this. We should test it in older browsers but i think using CSS will allow greater flexibility to stylers.

Comment 4

[Frédéric Buclin]

Attachment: patch, v2

OK, now using CSS. Tested on IE 6, IE8, Firefox, Safari, Opera, Google Chrome and Konqueror.

Comment 5

[Frédéric Buclin]

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.67; previous revision: 1.66
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.37; previous revision: 1.36
done