If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix Public Suffix List entry for .se

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: gerv, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
In the recent set of public suffix list updates, there was an error transcribing the entry for .se which the registry submitted. I found the error when reviewing the branch patch. The root "se" entry has been omitted - all there is is a list of permitted second-level domains. 

I _think_ this isn't bad, because foo.se (for a random value of 'foo') will fall back to the default rule of permitting cookies for foo.se but not se, but it's something we should fix.

Gerv
Do we need to fix this before 3.0.2 is released? We can if you do it soon.
(Reporter)

Comment 2

9 years ago
Sorry, I should have been more clear. I fixed it pre-checkin for 3.0.2, in bug 454816. This bug covers fixing it on the trunk, so the trunk matches the branch in this regard.

Gerv
Gerv: are you 100% sure that it's right on trunk? I'm beginning to think that this patch is riskier than I thought, and maybe it's just better to back it out and wait for 3.0.3.
Does the patch I checked in to the relbranch have the fix?

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/netwerk/dns/src&command=DIFF_FRAMESET&file=effective_tld_names.dat&rev1=1.6&rev2=1.6.6.1&root=/cvsroot
Ah, yes, looks like I used the right patch.
(Reporter)

Comment 6

9 years ago
beltzner: it's definitely right on trunk, and on the relbranch link above. Search for "se :". Note that the "se" entry has not been removed.

I'm also reasonably certain that even if it was wrong, the right thing would actually happen.
"If no rule matches, the first-level domain (the portion of the hostname after its last dot, or the entire hostname if it contains no dots) will be used, whether or not it appears in the file."
https://wiki.mozilla.org/Gecko:TLD_Service
So my analysis in comment 0 is correct.

Gavin: there's a relbranch? I checked with mconnor on IRC and he said there wasn't one... Sorry about that.

Gerv

Comment 7

9 years ago
Gerv's comment #6 is correct: "se" will be used as the default for any "foo.se" not covered by any other rule.  See http://mxr.mozilla.org/seamonkey/source/netwerk/dns/src/nsEffectiveTLDService.cpp#213  All the real TLDs in the file are good for clarity, but not required.
(Reporter)

Comment 8

9 years ago
So this got fixed on the relbranch, and it seems right here:
http://mxr.mozilla.org/firefox/source/netwerk/dns/src/effective_tld_names.dat

So resolving this as FIXED.

Gerv
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.