Closed Bug 455610 Opened 13 years ago Closed 13 years ago

Birthday fields for OS X address book incorrectly translated

Categories

(MailNews Core :: Address Book, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0a3

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
In testing out the patch for bug 13595, I noticed that the OS X Address Book birthday fields were wrong.

For dates I was getting 20xx in the day and month fields.

I took a quick look at the code, and found the problem - we're appending an int to a string three times, however, we're not truncating in between, and additionally we're using the dayOfWeek, not the dayOfMonth.

Attaching patch.
Attachment #338972 - Flags: superreview?(bienvenu)
Attachment #338972 - Flags: review?(bienvenu)
Attachment #338972 - Flags: superreview?(bienvenu)
Attachment #338972 - Flags: superreview+
Attachment #338972 - Flags: review?(bienvenu)
Attachment #338972 - Flags: review+
Checked in, changeset id: 352:96c4692bd6b1.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.