455611 - docshell's NavigationUtils.js needs to be tweaked a bit for Fenenc

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Doug Turner (:dougt)]

gBrowser in Fennec is not the same as the gBrowser in Firefox.  This function needs to be change a wee bit to get the right content windows from a chrome window.

http://mxr.mozilla.org/mozilla-central/source/docshell/test/navigation/NavigationUtils.js#131

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Use the docshell tree instead of tabbrowser methods. Tests pass in Firefox.

Comment 2

[Boris Zbarsky [:bzbarsky]]

That's odd....  The tests that use this really do want just the tabs and nothing else.

Can we restrict to those in some sane way?

(Is this the time when I get to mutter about needing a better tabbrowser API?)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The windows we get from the extra Firefox docshells are chrome windows, so we could easily filter them out, sure. I didn't bother because none of the tests are affected, since they always just look for the window's they've opened.

Comment 4

[Boris Zbarsky [:bzbarsky]]

I'd really prefer we filter them our if we can (esp. given the name of this method).

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Attachment: filter out non-content docshells

Comment 6

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/814f4b8ab48b