Closed Bug 455630 Opened 14 years ago Closed 14 years ago

"ASSERTION: Should never be called on an SVG frame"

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: longsonr)

References

Details

(Keywords: assertion, testcase)

Attachments

(1 file, 2 obsolete files)

Attached image testcase
###!!! ASSERTION: Should never be called on an SVG frame: '!svgChildFrame', file /Users/jruderman/central/layout/svg/base/src/nsSVGIntegrationUtils.cpp, line 245

###!!! ASSERTION: SVG frames should not get here: '!aNonSVGFrame->IsFrameOfType(nsIFrame::eSVG)', file /Users/jruderman/central/layout/svg/base/src/nsSVGIntegrationUtils.cpp, line 377
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #342777 - Flags: superreview?(roc)
Attachment #342777 - Flags: review?(roc)
OS: Mac OS X → All
Hardware: PC → All
Comment on attachment 342777 [details] [diff] [review]
patch

Reverse the order of the && checks.

But you might want to also check whether filters on the outermost <svg> element actually work; I suspect they're broken. If so, please file a new bug for that.
Attachment #342777 - Flags: superreview?(roc)
Attachment #342777 - Flags: superreview+
Attachment #342777 - Flags: review?(roc)
Attachment #342777 - Flags: review+
Depends on: 459758
You are right, filters on the outermost SVG element only work via this code path and therefore a) don't work on 3.0 and b) would stop working when this patch lands.

bug 459758 raised.
Attached patch address sr comment (obsolete) — Splinter Review
Attachment #342777 - Attachment is obsolete: true
Fixed by check in for bug 459758
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #342960 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.