Closed
Bug 455670
Opened 16 years ago
Closed 16 years ago
Clear MOZ_FIX_LINK_PATHS for Solaris
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
|
961 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
MOZ_FIX_LINK_PATHS is no use on Solaris.
Having -R ${LIBXUL_DIST}/bin will cause the final binary have a runpath as "../../dist/bin".
Then it tries to find library from ../../dist/bin, it's not good for end user.
Assignee: nobody → ginn.chen
Attachment #339038 -
Flags: review?(benjamin)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 339038 [details] [diff] [review]
patch
So the question is, what are you going to use in its place? There are components that link against -lxpcom but explicitly don't link against the dependencies of -lxpcom (in particular -lxul or the NSS libs)... how will these be found?
We already have $ORIGIN:$ORIGIN/.. in runpath.
So libraries in /usr/lib/firefox or first level subdirectory under it are fine.
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 339038 [details] [diff] [review]
patch
If $ORIGIN is honored at link-time in addition to runtime, that makes sense.
Attachment #339038 -
Flags: review?(benjamin) → review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•