455818 - Some editor movement tests need to be fixed for Windows

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=454004#c29. The failing tests have been disabled temporarily.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

There were two problems with the tests, the first was due to the difference
in the default value for the pref "layout.word_select.eat_space_to_next_word"
between platforms, which affects "cmd_selectWordNext".
The second problem was caused by font/line-height differences which affects
how many lines to scroll for a page scroll.

I wrapped all the commands that involves selection in a function and
run it twice (eat_space_to_next_word=true/false) to check that only
"cmd_selectWordNext" is affected (and with correct values for each).

The second problem was fixed by hard-coding some font-size/line-height
etc styles.  (I also fixed a few Windows ^M line-endings)

The test now passes on Windows/Linux/MacOSX for me.

Comment 2

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1 (diff -uw)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 339257 [details] [diff] [review]
Patch rev. 1 (diff -uw)

Looks good. Only thing I'd add is some exception-catching so that if we throw an exception during the test the pref value is restored to its original value.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Thanks a lot!

Comment 5

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Wrapped the pref changes in a try-finally block to address comment 3.

Comment 6

[Mats Palmgren (inactive)]

http://hg.mozilla.org/mozilla-central/rev/0a7fa17fe202

-> FIXED