455913 - nsIHelperAppLauncher should provide info about content length

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Proposed fix

I think it would be nice to have information about download content size before download starting, especially for mobile using.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 339286 [details] [diff] [review]
Proposed fix

+   * The download content length. It might not be available in some cases.

How about:

  * The download content length, or -1 if the length is not available.

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Patch to checkin with fixed comment

Comment 3

[Oleg Romashin (:romaxa)]

Fixed:
http://hg.mozilla.org/mozilla-central/rev/81f3072d75be

Comment 4

[Boris Zbarsky [:bzbarsky]]

This needed an iid rev, no?

Comment 5

[Oleg Romashin (:romaxa)]

You mean we should change uuid? like this:

-[scriptable, uuid(cc75c21a-0a79-4f68-90e1-563253d0c555)]
+[scriptable, uuid(d9a19faf-497b-408c-b995-777d956b72c0)]
?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Sorry for missing that :/

r+sr=biesi on the IID change

Comment 7

[Oleg Romashin (:romaxa)]

pushed iid fix:
http://hg.mozilla.org/mozilla-central/rev/6ec53662fbef

Comment 8

[scorpion]

Hello,

nsIHelperAppLauncher contentLength doesn't work in Mozilla Thunderbird for mailbox url's.

I always get 11206112 bytes.