Open Bug 455940 Opened 12 years ago Updated 3 years ago
Blow away the dist directory for top level makes
if you backout a file, the tinderboxes need to be clobbered to get rid of it, and it can cause all sorts of strange issues. It'd be nice if it just worked.
This is thankfully simple enough.
Attachment #340275 - Flags: review?(ted.mielczarek)
Attachment #340275 - Flags: review?(ted.mielczarek) → review?(benjamin)
Comment on attachment 340275 [details] [diff] [review] v1.0 Ted thinks this would be better reviewed by bsmedgberg
Whiteboard: [has patch][needs review ted] → [has patch][needs review bsmedberg]
Comment on attachment 340275 [details] [diff] [review] v1.0 please remove all of dist/bin
Attachment #340275 - Flags: review?(benjamin) → review+
Addressed on checkin: http://hg.mozilla.org/mozilla-central/rev/2039bfc05310
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Blow away the components directory for top level makes → Blow away the dist directory for top level makes
Whiteboard: [has patch][needs review bsmedberg]
Did you really want to remove $(DIST)/dist/bin or just $(DIST)/bin?
Addressed comment 5 in http://hg.mozilla.org/mozilla-central/rev/541fc3b73d52 since the windows builds were staying orange.
Backed out completely: http://hg.mozilla.org/mozilla-central/rev/cb3240bf1d9b since it turned the Windows boxes (builders, unit testers) red.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I relanded with $(DIST)/bin/components in the hope that that will remove the file we need to remove right now to get Windows green again without having to poke at the Windows machines (and end up with color depth problems, etc., etc.): http://hg.mozilla.org/mozilla-central/rev/1c2231730ff9
Also, if we remove dist/bin, we should remove dist/Firefox.app or whatever the appropriate *.app directory is.
Shawn: are you interested in investigating/fixing this, or would you rather I took it?
It might be better for someone more knowledgeable about the build system to take this. At this point, I'd be asking you all sorts of questions to fix it... (at least to address comment 10)
(In reply to comment #11) > Shawn: are you interested in investigating/fixing this, or would you rather I > took it? I'd rather you take this ted.
Assignee: sdwilsh → ted.mielczarek
Note that blowing away $DIST/bin/components is part of the problem in bug 468285.
You need to log in before you can comment on or make changes to this bug.