456008 - [FIX]Dynamically loaded flash does not render in XHTML.

Status: VERIFIED FIXED

(Core :: XML, defect, P3)

Description

[Michiel Meeuwissen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1

This XHTML page does not render the flash object that is loaded with ajax into the page. (using jquery). Other elements, like text, style, and an image are rendered correctly.

If you try to render the included piece of xhtml directly (http://www.meeuw.org/flash/flash.xhtml), then it _is rendered_.

Reproducible: Always

Steps to Reproduce:
1.Goto http://www.meeuw.org/flash/
2.See that there is no flash animation to be seen
3.In firebug you see that the <object> _is_ in the page

Actual Results:  
The flash object does not appear.

Expected Results:  
The page http://www.meeuw.org/flash/flash.xhtml should have been visible entirely, including the flash movie.

Tested also with a nightly build 3.1bpre

Does work in FF2.
Does also work in opera 9.5.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed on Windows XP/Vista. 

Works: 2008041712
Fails: 2008041717

Regression window is:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2008-04-17+11%3A00&maxdate=2008-04-17+18%3A00

Apperas to be caused by Bug 419716.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Does it work if you reverse the order of the attributes in the <object> tag?

It's very unfortunate, but flash does depend on that order. We've been juggling it quite a bit and I'm not sure what we finally landed on.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, but this works in HTML, no?  I really wonder what jquery is doing here and whether it's possible to create a smallish testcase with just the relevant part of jquery.  That would help immensely.

Comment 4

[Michiel Meeuwissen]

The order of comments of the attributes does not seem to matter. In the cited demo I now have 6 times the same flash movie, only with different order of attributes. (Happily) that does not make a difference, and they all don't work.

It does work in HTML. See:
http://www.meeuw.org/flash/html.html
This is a symlink to index.xhtml, where the differnent extension makes apache serves it out as text/html.

I'll do my best to reduce the test-case and eliminate jquery.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I bet the problem is that the HTML fragment sink passes PR_FALSE for aFromParser whilete XML fragment sink passes PR_TRUE and never calls DoneCreatingElement or such.  The XML fragment sink needs fixing here, and we should fix this on branch as well, since it's a regression there too...

Comment 6

[Boris Zbarsky [:bzbarsky]]

This problem should be noticeable with other nodes that rely on DoneCreatingElement or DoneAddingChildren as well, I would think, for ease of test-writing.

Comment 7

[Michiel Meeuwissen]

Ok. I removed jquery from the test. I include the included page now twice, in two different manners. First using innerHTML = res.responseText, and the second time using responseXML and appendChild. The second method _does_ work. 

That may throw some light on the issue.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Yeah, that basically means comment 5 is right.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix + tests

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 340062 [details] [diff] [review]
Fix + tests

We should fix this on branch too.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Pushed changeset cd35d2072d63.  Michiel, thanks for the excellent testcase and the help getting to the bottom of this!

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 340062 [details] [diff] [review]
Fix + tests

Approved for 1.9.0.4, a=dveditz for release-drivers

Comment 13

[Boris Zbarsky [:bzbarsky]]

Fixed on 1.9 branch.

Comment 14

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.0.4 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.4pre) Gecko/2008102304 GranParadiso/3.0.4pre. 

Verified for trunk with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081023 Minefield/3.1b2pre.