456054 - TC uses fixed 512K stack for all platforms except windows

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Lars T Hansen]

See Shell::computeStackBase in avmshell.cpp.  A hard limit is wrong on every system - on small systems it's too high, on large systems too low.  Presumably products incorporating TC does better, but we should do better for the shell too.

Comment 1

[Lars T Hansen]

The Windows code is OK.  On Mac and Linux we should use getrlimit().  This has anyway been factored into the platform layer.

Comment 2

[Lars T Hansen]

Attachment: Bug fix, v1

The fix has several aspects:

 - Platform::getStackBase is renamed as Platform::getMainThreadStackLimit (all
   together now, this does not make sense on a thread stack) and is given
   proper documentation about that and other things

 - On Mac and Unix, the code that creates the Platform object passes in an
   estimate of the stack base (highest address) so that the above mentioned
   method will have something to work from

 - The method implementations on Mac and Unix use the Posix getrlimit() system
   call to obtain the stack size, and computes the true stack limit based on
   the stack base and the stack size

 - On /all/ platforms, a /standardized/ slop for native code is added to the
   limit.  We know this slop not to be as good as it needs to be (because we
   don't know how much space native code might need, for one thing) but it's
   better to do it the same way across the board than differently on different
   platforms.

Comment 3

[Lars T Hansen]

redux changeset:   1793:45a3367b83b4