456136 - Switching tabs with space moves focus back to the toolbar

Status: RESOLVED WONTFIX

(Camino Graveyard :: Accessibility, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR:

0) Have two or more tabs present and FKA active
1) Tab to an inactive tab
2) Press space
3) Observe the focus ring

ER: Focus ring on the current tab
AR: Focus ring on the first focusable item in the main toolbar

Comment 1

[philippe (part-time)]

I can seem to reproduce this here (2008091919 tinderbox build).
tab 1 is wikipedia front page
tab 2 is a default Apache directory listing on my dev server

With tab 1 active: 
1. command L
2. then tab through to set focus on tab 2
3. press spacebar

result:
tab2 becomes active/in front
no focus ring (as expected, actually) anywhere
tab then selects the first link on the page.

Comment 2

[philippe (part-time)]

(In reply to comment #1)
> I can seem to reproduce this here (2008091919 tinderbox build).
s/can/can not
sorry about that

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

OK, the page I was testing before for page 2 had no focusable form controls (and I have links off), so there's theoretically no-where for the focus to go (but on the page), but I'm not sure how focus ended up jumping two positions.  I suppose I could have hit tab once and not remembered, but not twice.

In Safari, though, focus ring remains on the newly-active tab's tab widget after pressing space (and, generally, that's how tab widgets work, even ones where you use arrow rather than tab to move to the next tab).

Comment 4

[philippe (part-time)]

With those settings in comment 3, after pressing spacebar, the tab becomes active and the focus is on the page content. Next time I press tab, if there is a focus-able element on the page (like Wikipedia), it gets the focus, otherwise the focus moves to the first focus-able element on the toolbar (back button or reload button in my case). That is basically the same result then I get in comment 1.

This has an advantage: I can immediately interact with the page.

Same thing with a folder on the BM bar. Tab to it, once focussed, press spacebar, the folder opens, arrow down, select bookmark, press return, page loads. Once the page is fully loaded, Camino sets the focus on the page, with Safari the focus is still on the BM bar.

Comment 5

[Sean Murphy]

(In reply to comment #0)
> STR:
> 
> 0) Have two or more tabs present and FKA active
> 1) Tab to an inactive tab
> 2) Press space
> 3) Observe the focus ring
> 
> ER: Focus ring on the current tab
> AR: Focus ring on the first focusable item in the main toolbar

You know what, I originally had some code in to restore the first responder back to the focused TabButtonView, but then intentionally decided to leave it out for the very advantage that philippe mentioned.

The reason the tab actually loses focus focus is because, when a new TabViewItem is selected, all of the TabButton subviews are removed during -[BrowserTabBarView layoutButtons...].  I can re-introduce the code to preserve the focus ring on the tab, if this is behavior we want.

Comment 6

[philippe (part-time)]

Here is how Transmit behaves in a similar situation:

1. open multiple (3) tabs in Transmit, with focus on last (tab 3) tab.
2. tab around, set focus on tab 1
3. spacebar to make tab 1 the active tab.

result:
a. tab 1 is activated, the focus ring is still on the tab-title.
b. hit tab key, focus is moved to first focus-able element inside tab 1 [1]: I can immediately interact with the content of tab 1.

In Safari, at that point, the focus would move to tab 2 then tab 3 then to the content inside tab 1.

[1] a select widget in my set up.

Comment 7

[Gordon P. Hemsley [:GPHemsley]]

This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX.

[Mass-change filter: graveyard-wontfix-2014-09-24]