Closed Bug 456176 Opened 16 years ago Closed 16 years ago

Hitting tab key focuses a Tab even if Full Keyboard Access is off

Categories

(Camino Graveyard :: Accessibility, defect)

Product:
Camino Graveyard
Component:
Accessibility
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Camino2.0

People

(Reporter: suishouen, Assigned: stuart.morgan+bugzilla)

References

Details

Attachments

(2 files)

Screenshot
21.07 KB, image/png
Details
fix
1.26 KB, patch
murph
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en; rv:1.9.0.3pre) Gecko/2008092000 Camino/2.0a1pre (like Firefox/3.0.3pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en; rv:1.9.0.3pre) Gecko/2008092000 Camino/2.0a1pre (like Firefox/3.0.3pre)

Since bug 152987 and friends have been fixed, hitting tab focuses a Tab even if Full Keyboard Access is off and set Web Features > Tab selects > Text field.

Reproducible: Always
Attached image Screenshot — 

    
  
Summary: Hitting tab focuses a Tab even if Full Keyboard Access is off → Hitting tab key focuses a Tab even if Full Keyboard Access is off

    
    

    
  
Odd.  I couldn't reproduce this last night, but I can reproduce it almost 100% of the time now.
Blocks: 383871
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fix
        — 
          — Splinter Review
      

    


  
I'm not wild about this solution, but it works, and after looking around for a while I couldn't find anything better for the short term. Long term, perhaps NSView isn't the right parent class for our tabs.
Assignee: nobody → stuart.morgan+bugzilla
Status: NEW → ASSIGNED

        Attachment #339605 -
        Flags: review?(murph)

    
    

    
  
Comment on attachment 339605 [details] [diff] [review]
fix

r=murph.

(In reply to comment #3)
> Created an attachment (id=339605) [details]
> fix
> 
> I'm not wild about this solution, but it works, and after looking around for a
> while I couldn't find anything better for the short term. Long term, perhaps
> NSView isn't the right parent class for our tabs.

Switching the parent class could also mean we would not need our manual spacebar keyDown: handling code as well :)

        Attachment #339605 -
        Flags: review?(murph) → review+

    
  

        Attachment #339605 -
        Flags: superreview?(mikepinkerton)

    
  
Hardware: PC → All

    
    

    
  
Comment on attachment 339605 [details] [diff] [review]
fix

sr=pink

        Attachment #339605 -
        Flags: superreview?(mikepinkerton) → superreview+

    
    

    
  
Landed on cvs trunk.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Camino2.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: