Closed Bug 456232 Opened 13 years ago Closed 13 years ago

NewAPI: Add basic web navigation support to MozView

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

This patch adds support for Reload, GoBack and GoForward (Stop was already implemented). Also add CanGoForward and CanGoBack. These changes were made to embed.h/cpp

The patch also exposes the methods in the win32 application. The resource files are updated to add the commands to the menu, so there are some big, autogenerated diffs in those files. The main win32 sample cpp file has a lot of TAB->SPACES surgery too, making the diff very large. The main code changes to win32_test.cpp are in the WndProc: added handlers for the menus and added WM_INITPOPUPMENU handler to enable/disable the Back and Forward menus.
Attachment #339620 - Flags: review?(pelle.johnsen)
r+, great you also got the win32 file cleanup up. Guess it has been a bit messy from the start with respect to indention.

Seams like I don't have access rights to properly r+ the attachment, so hope this will do :)
Comment on attachment 339620 [details] [diff] [review]
Adds basic web navigation support

Set the r+ on pelle's behalf
Attachment #339620 - Flags: review?(pelle.johnsen) → review+
(In reply to comment #1)
> Seams like I don't have access rights to properly r+ the attachment

I've granted you editbugs+canconfirm, so you should be able to from now on, fwiw.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.