456256 - Resolve what to do with respect to completeDefaultIndex/autoFill/autoFillAfterMatch on SeaMonkey xpfe.

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Mark Banner (:standard8)]

After bug 325842 we have three attributes on xpfe autocomplete which do roughly the same thing:

- autoFill
  This will extend the entry with a highlighted selection if the start of the entry matches the autocomplete suggestion.
- autoFillAfterMatch
  Similar to autoFill, but if the string does not match the start of the best autocomplete suggestion, then it will indicate a match in the form "ar >> Mark" to indicate the replacement.
- completeDefaultIndex
  This is the same as turning on autoFill and autoFillAfterMatch.

Comment 1

[[e-mail]]

I think we should just switch everyone over from autoFillAfterMatch to completeDefaultIndex (and remove autoFillAfterMatch).

Comment 2

[Caio Tiago Oliveira (asrail)]

Sorry for setting the keyword... this "autocompletion" thing added it from nothing when I clicked on the field.

Comment 3

[[e-mail]]

Attachment: What I said in comment #1

I'm assuming here that Calendar can stop using those really old attributes ;-)

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 340740 [details] [diff] [review]
What I said in comment #1

Looks good. I definitely agree we don't need those old attributes in the calendar file.

r=me.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 340740 [details] [diff] [review]
What I said in comment #1

Looks good, r=philipp

Comment 6

[[e-mail]]

Pushed changeset b990b5896c48 to comm-central.

Still need to remove autoFillAfterMatch from mozilla-central.

Comment 7

[[e-mail]]

Attachment: Remove autoFillAfterMatch

Conveniently the comment still applies to completeDefaultIndex ;-)

Comment 8

[[e-mail]]

Pushed changeset 5d202f0c69e9 to mozilla-central.

Pushed changeset e40d9b4121f4 to releases/mozilla-1.9.1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1d9491c42039
autoFillAfterMatch is now completeDefaultIndex r+sr=jag NPOFB