Closed Bug 456458 Opened 11 years ago Closed 11 years ago

JS Tracer uses file-system stat structure name - WinCE compile fails

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Windows Mobile 6 Professional
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: wolfe, Assigned: dougt)

References

Details

(Keywords: mobile)

Attachments

(1 file, 1 obsolete file)

Need to change a local statistics structure name from stat to something else (like jstracer_stat) to avoid a compiler error due to already-defined stat structure in WinCE shunt library.

No real change to code, just a change to the name of a structure only used within the jstracer.cpp file
Attachment #339859 - Flags: review?(crowder)
Comment on attachment 339859 [details] [diff] [review]
Renaming of structure from stat to jstracer_stat in jstracer.cpp

I suspect this is a bit out-of-date, are you sure it still applies and builds cleanly?  (in debug and release?)
the patch works for me on windows ce opt.
yeah, there are a few more in this file that need to be hit.
Attached patch patch v.1Splinter Review
Assignee: nobody → doug.turner
Attachment #339859 - Attachment is obsolete: true
Attachment #339965 - Flags: review?
Attachment #339859 - Flags: review?(crowder)
Attachment #339965 - Flags: review? → review+
Comment on attachment 339965 [details] [diff] [review]
patch v.1

For brevity's sake, let's call this "jitstats" instead of "jstracer_stat".  Otherwise, looks good.
checked in on Tue Sep 23 21:10:58 2008 -0700
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
winmo builds are building just fine.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.