JS Tracer uses file-system stat structure name - WinCE compile fails

VERIFIED FIXED

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: wolfe, Assigned: dougt)

Tracking

({mobile})

Trunk
ARM
Windows Mobile 6 Professional
mobile

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 years ago
Created attachment 339859 [details] [diff] [review]
Renaming of structure from stat to jstracer_stat in jstracer.cpp

Need to change a local statistics structure name from stat to something else (like jstracer_stat) to avoid a compiler error due to already-defined stat structure in WinCE shunt library.

No real change to code, just a change to the name of a structure only used within the jstracer.cpp file
Attachment #339859 - Flags: review?(crowder)

Comment 1

10 years ago
Comment on attachment 339859 [details] [diff] [review]
Renaming of structure from stat to jstracer_stat in jstracer.cpp

I suspect this is a bit out-of-date, are you sure it still applies and builds cleanly?  (in debug and release?)
(Assignee)

Comment 2

10 years ago
the patch works for me on windows ce opt.
(Assignee)

Comment 3

10 years ago
yeah, there are a few more in this file that need to be hit.
(Assignee)

Comment 4

10 years ago
Created attachment 339965 [details] [diff] [review]
patch v.1
Assignee: nobody → doug.turner
Attachment #339859 - Attachment is obsolete: true
Attachment #339965 - Flags: review?
Attachment #339859 - Flags: review?(crowder)

Updated

10 years ago
Attachment #339965 - Flags: review? → review+

Comment 5

10 years ago
Comment on attachment 339965 [details] [diff] [review]
patch v.1

For brevity's sake, let's call this "jitstats" instead of "jstracer_stat".  Otherwise, looks good.
(Assignee)

Comment 6

10 years ago
checked in on Tue Sep 23 21:10:58 2008 -0700
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
winmo builds are building just fine.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.