Closed Bug 456489 Opened 11 years ago Closed 11 years ago

WinCE Compiler keyword interface used in mozStorageRow.cpp

Categories

(Toolkit :: Storage, defect)

ARM
Windows Mobile 6 Professional
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: wolfe, Assigned: wolfe)

References

Details

(Keywords: mobile)

Attachments

(1 file, 1 obsolete file)

Need to use a different local variable name than "interface" - which causes the Microsoft compiler to produce errors.
Attachment #339887 - Flags: review?(doug.turner)
Component: General → Storage
Product: Fennec → Toolkit
QA Contact: general → storage
Comment on attachment 339887 [details] [diff] [review]
Change the local variable 'interface' to 'interface_iid'

r=sdwilsh as long as you change the variable name to either interfaceIID or just iid.
Attachment #339887 - Flags: review?(doug.turner) → review+
Change the local variable 'interface' to 'interfaceIID', as per Shawn's request

Otherwise, the patch is the same as previously.
Attachment #339887 - Attachment is obsolete: true
Attachment #339901 - Flags: review?(sdwilsh)
This bug is a slippery slope! Please, let's fix this a different way (or try to)
"interface" is a compiler define, not a keyword. Let's just try to #undef it in the IDL.
Comment on attachment 339901 [details] [diff] [review]
Change the local variable 'interface' to 'interfaceIID'

For future reference, if someone says r=them with comments, you don't have to ask for review again.

r=sdwilsh

(In reply to comment #4)
> "interface" is a compiler define, not a keyword. Let's just try to #undef it in
> the IDL.
It's OK since the new name is more accurate anyway.
Attachment #339901 - Flags: review?(sdwilsh) → review+
Assignee: nobody → wolfe
checked in on Tue Sep 23 21:10:58 2008 -0700
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.