WinCE Compiler keyword interface used in mozStorageRow.cpp

RESOLVED FIXED

Status

()

Toolkit
Storage
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: wolfe, Assigned: wolfe)

Tracking

({mobile})

Trunk
ARM
Windows Mobile 6 Professional
mobile
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 339887 [details] [diff] [review]
Change the local variable 'interface' to 'interface_iid'

Need to use a different local variable name than "interface" - which causes the Microsoft compiler to produce errors.
Attachment #339887 - Flags: review?(doug.turner)
Component: General → Storage
Product: Fennec → Toolkit
QA Contact: general → storage
Comment on attachment 339887 [details] [diff] [review]
Change the local variable 'interface' to 'interface_iid'

r=sdwilsh as long as you change the variable name to either interfaceIID or just iid.
Attachment #339887 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 2

10 years ago
Created attachment 339901 [details] [diff] [review]
Change the local variable 'interface' to 'interfaceIID'

Change the local variable 'interface' to 'interfaceIID', as per Shawn's request

Otherwise, the patch is the same as previously.
Attachment #339887 - Attachment is obsolete: true
Attachment #339901 - Flags: review?(sdwilsh)
This bug is a slippery slope! Please, let's fix this a different way (or try to)
"interface" is a compiler define, not a keyword. Let's just try to #undef it in the IDL.
Comment on attachment 339901 [details] [diff] [review]
Change the local variable 'interface' to 'interfaceIID'

For future reference, if someone says r=them with comments, you don't have to ask for review again.

r=sdwilsh

(In reply to comment #4)
> "interface" is a compiler define, not a keyword. Let's just try to #undef it in
> the IDL.
It's OK since the new name is more accurate anyway.
Attachment #339901 - Flags: review?(sdwilsh) → review+

Updated

10 years ago
Assignee: nobody → wolfe

Comment 6

10 years ago
checked in on Tue Sep 23 21:10:58 2008 -0700
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.