Closed Bug 456522 Opened 14 years ago Closed 14 years ago

In <nsPresContext.h>, 4 "warning C4244: 'argument' : conversion from 'PRInt32' to 'float', possible loss of data"

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: sgautherie, Assigned: masayuki)

Details

Attachments

(1 file)

Patch v1.0
1.86 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review 
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b1pre) Gecko/20080917032624 Minefield/3.1b1pre] (home, optim default) (W2Ksp4)

{
objdir\dist\include\layout\nsPresContext.h(528) : warning C4244: 'argument' : conversion from 'PRInt32' to 'float', possible loss of data
objdir\dist\include\layout\nsPresContext.h(532) : warning C4244: 'argument' : conversion from 'PRInt32' to 'float', possible loss of data
objdir\dist\include\layout\nsPresContext.h(536) : warning C4244: 'argument' : conversion from 'PRInt32' to 'float', possible loss of data
objdir\dist\include\layout\nsPresContext.h(547) : warning C4244: 'argument' : conversion from 'PRInt32' to 'float', possible loss of data
}
Attached patch Patch v1.0 — — Splinter Review 
simple fix.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Attachment #343184 - Flags: superreview?(roc)
Attachment #343184 - Flags: review?(roc)
Attachment #343184 - Flags: superreview?(roc)
Attachment #343184 - Flags: superreview+
Attachment #343184 - Flags: review?(roc)
Attachment #343184 - Flags: review+
Ftr, isn't this more of a wallpaper than a fix ?
checked-in.

(In reply to comment #2)
> Ftr, isn't this more of a wallpaper than a fix ?

The patch should not have problems. Because the values are not such large value.
oops,

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Good, that's just what I wanted to know.

***

V.Fixed.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.1b2
You need to log in before you can comment on or make changes to this bug.