456548 - IMAP subfolders not initialized beyond one level in GetSubFolders

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch v1

GetSubFolders for IMAP is not recursive, as a result of which subfolders beyond one level aren't initialized in GetSubFolders. This results in a crash while opening a Windows Search/Spotlight result, because nsMessengerBootstrap::OpenMessengerWindowWithUri assumes that the whole folder tree has been initialized by then, when it clearly hasn't for subfolders beyond one level.

It seems like the frontend is currently responsible for initializing an IMAP folder tree, and this assumption isn't really valid when opening a result from the command line.

David, is this correct? Everything seems to work fine, even if disk storage and msfs are deleted. It'd be great if this makes b1.

Comment 1

[David :Bienvenu]

Comment on attachment 339942 [details] [diff] [review]
patch v1

Did you try making nsImapMailFolder::CreateSubFolders recursive? That seems a bit more natural.

Comment 2

[Rain [:rain1] (inactive)]

(In reply to comment #1)
> (From update of attachment 339942 [details] [diff] [review])
> Did you try making nsImapMailFolder::CreateSubFolders recursive? That seems a
> bit more natural.

In fact, I've just replicated what's done in nsLocalMailFolder. Would you rather we called GetSubFolders for each subfolder inside CreateSubFolders?

Comment 3

[David :Bienvenu]

thx for fixing this; it will help with the kill-rdf stuff as well.

Comment 4

[Mark Banner (:standard8)]

Checked in, changeset id: 405:e842bdf573c3