456588 - localize var scope to nearest block enclosing def and uses if def dominates uses

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P2)

Description

[Brendan Eich [:brendan]]

This is needed to handle union types of (undefined, double), (undefined, string), etc. in TM.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: draft patch

Needs cleanup and testing/tests.

/be

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #1)
> Created an attachment (id=438690) [details]
> draft patch
> 
> Needs cleanup and testing/tests.
> 
> /be

Ready for fuzz testing?

Comment 3

[Brendan Eich [:brendan]]

Attachment: backup, still not ready for fuzzing

Comment 4

[Brendan Eich [:brendan]]

IIRC bhackett's JM analysis does this. Plus, we want to get into better front end and high-level intermediate reps (Shu's SSA in one pass work). So this should not be rushed in terms of the current def/use chains.

/be

Comment 5

[Brendan Eich [:brendan]]

I think bhackett has this one, possibly even under another bug.

/be

Comment 6

[Chris Peterson [:cpeterson]]

Brian: is this bug still relevant?

Comment 7

[Brian Hackett [Laid off!]]

I think the SSA analysis done by Ion (and before, by JM+TI) captures this.