Closed Bug 456588 Opened 12 years ago Closed 6 years ago

localize var scope to nearest block enclosing def and uses if def dominates uses

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: brendan, Assigned: bhackett1024)

References

Details

(Whiteboard: DUPEME)

Attachments

(1 file, 1 obsolete file)

This is needed to handle union types of (undefined, double), (undefined, string), etc. in TM.

/be
Blocks: 456479
Blocks: 453730
No longer blocks: 456479
Blocks: 451514
No longer blocks: 451514
Severity: normal → enhancement
No longer blocks: 453730
Severity: enhancement → major
Depends on: upvar2
Priority: -- → P2
Summary: Hoist var initializer of right type along with var binding → localize var scope to nearest block enclosing def and uses if def dominates uses
Target Milestone: mozilla1.9.1b1 → mozilla1.9.1
Target Milestone: mozilla1.9.1 → mozilla1.9.2a1
Target Milestone: mozilla1.9.2a1 → mozilla1.9.3
Priority: P2 → P1
Target Milestone: mozilla1.9.3 → mozilla1.9.3a5
Attached patch draft patch (obsolete) — Splinter Review
Needs cleanup and testing/tests.

/be
(In reply to comment #1)
> Created an attachment (id=438690) [details]
> draft patch
> 
> Needs cleanup and testing/tests.
> 
> /be

Ready for fuzz testing?
Attachment #438690 - Attachment is obsolete: true
IIRC bhackett's JM analysis does this. Plus, we want to get into better front end and high-level intermediate reps (Shu's SSA in one pass work). So this should not be rushed in terms of the current def/use chains.

/be
Status: ASSIGNED → NEW
Target Milestone: mozilla1.9.3a5 → ---
I think bhackett has this one, possibly even under another bug.

/be
Assignee: brendan → bhackett1024
Whiteboard: DUPEME
Brian: is this bug still relevant?
Flags: needinfo?(bhackett1024)
Priority: P1 → P2
I think the SSA analysis done by Ion (and before, by JM+TI) captures this.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(bhackett1024)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.