Closed
Bug 456601
Opened 16 years ago
Closed 10 years ago
Thunderbird loses track of most of the messages in a folder, because all our cached connections are used
Categories
(MailNews Core :: Backend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: dmosedale, Assigned: Bienvenu)
Details
(Keywords: regression, Whiteboard: [patch for improved sanity checking wanted])
Attachments
(1 file)
828 bytes,
patch
|
dmosedale
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
In my case, the INBOX. davida has seen this as well. It's likely to freak users out, so this should block beta1. I've sent bienvenu a protocol log, and he has a patch that he thinks might do the trick.
Flags: blocking-thunderbird3+
Assignee | ||
Comment 1•16 years ago
|
||
I think this should prevent this from happening again - I'm still looking into recovering from this situation, but this patch should help. It should prevent those "foundit" assertions you've been seeing as well. The autosync stuff exposed an existing problem in how cached connections and condstore played together, by basically using all our cached connections for its work. This fix makes it so when we re-use a cached connection, in particular, its flag state, that we start off the flag state in "partial" mode.
Attachment #339992 -
Flags: superreview?(dmose)
Attachment #339992 -
Flags: review?(dmose)
Reporter | ||
Comment 2•16 years ago
|
||
Comment on attachment 339992 [details] [diff] [review] possible fix r+sr=dmose
Attachment #339992 -
Flags: superreview?(dmose)
Attachment #339992 -
Flags: superreview+
Attachment #339992 -
Flags: review?(dmose)
Attachment #339992 -
Flags: review+
Assignee | ||
Comment 3•16 years ago
|
||
fix checked in, changeset: 415:0873795c1cc4 I'd still like to improve the sanity checking that would have ameliorated this bug, but that requires a bit more thought.
Updated•16 years ago
|
Whiteboard: [patch for improved sanity checking wanted]
Reporter | ||
Comment 4•16 years ago
|
||
Presumably, the patch that's gone in should be good enough for beta 1. Moving the target milestone out; feel free to reset if my presumption is wrong.
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
Assignee | ||
Comment 5•16 years ago
|
||
Yes, I believe the patch that went in will fix the underlying issue - if it doesn't completely fix it, then this will have to move back to b1. I will try to have a patch that adds more sanity checking in hand, though. We already do sanity checking if the mailbox changes at all, which helps mostly with the inbox. And we sanity check all the time if you're using the imap delete model.
Assignee | ||
Comment 6•16 years ago
|
||
moving to b2 - I haven't heard any more reports of this.
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
Assignee | ||
Comment 7•16 years ago
|
||
moving past b2
Target Milestone: Thunderbird 3.0b2 → Thunderbird 3.0rc1
Assignee | ||
Comment 8•15 years ago
|
||
taking off blocker list.
Flags: blocking-thunderbird3+ → blocking-thunderbird3-
Comment 9•12 years ago
|
||
(In reply to David :Bienvenu from comment #5) > Yes, I believe the patch that went in will fix the underlying issue - if it > doesn't completely fix it, then this will have to move back to b1. I will > try to have a patch that adds more sanity checking in hand, though. We > already do sanity checking if the mailbox changes at all, which helps mostly > with the inbox. And we sanity check all the time if you're using the imap > delete model. should we close this and file new bug? Or has the above already been fixed elsewhere?
Flags: needinfo?
Comment 10•10 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #9) > (In reply to David :Bienvenu from comment #5) > > I will > > try to have a patch that adds more sanity checking in hand, though. We > > already do sanity checking if the mailbox changes at all, which helps mostly > > with the inbox. And we sanity check all the time if you're using the imap > > delete model. David, do you think we still need a followup bug?
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo? → needinfo?(mozilla)
Keywords: regression
OS: Mac OS X → All
Resolution: --- → FIXED
Summary: Thunderbird loses track of most of the messages in a folder → Thunderbird loses track of most of the messages in a folder, because all our cached connections are used
Comment 11•10 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #10) > (In reply to Wayne Mery (:wsmwk) from comment #9) > > (In reply to David :Bienvenu from comment #5) > > > I will > > > try to have a patch that adds more sanity checking in hand, though. We > > > already do sanity checking if the mailbox changes at all, which helps mostly > > > with the inbox. And we sanity check all the time if you're using the imap > > > delete model. > > David, do you think we still need a followup bug? should we PM david about this one?
Flags: needinfo?(mozilla)
Flags: needinfo?(kent)
Flags: needinfo?(irving)
Comment 12•10 years ago
|
||
If we're not getting bug reports related to a 5 year old change, I think we should just drop it.
Flags: needinfo?(irving)
Comment 13•10 years ago
|
||
I agree with Irving, if there are no new reports of this then we should move on.
Flags: needinfo?(kent)
You need to log in
before you can comment on or make changes to this bug.
Description
•