Closed Bug 456606 Opened 13 years ago Closed 8 years ago

test_punycodeURIs.js failure on Mac OS X 10.4 (currently worked around)

Categories

(Core Graveyard :: File Handling, defect)

1.9.2 Branch
PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kairo, Unassigned)

References

()

Details

Attachments

(1 file, 1 obsolete file)

bug 378991 introduced a test that fails on Mac OS X 10.4 which we papered over in bug 447999 by excluding Tiger from that test for now, but we really should investigate why we run into that failure, as this might be a real code problem.
Depends on: 559699
Version: Trunk → 1.9.2 Branch
Comment on attachment 439747 [details] [diff] [review]
(Av1) Remove a useless createInstance(), Whitespace cleanup, Remove MacOSX 10.4 workaround (on m-c)

Please don't change these var to let as long as the rest of the file uses var. If you want to clean up the entire file that's ok but please make a separate patch for that.

So the only actual change in this patch is to reenable the test on MacOS 10.4, right? Does it no longer fail there?
Attachment #439747 - Flags: review?(cbiesinger) → review-
(In reply to comment #2)
> So the only actual change in this patch is to reenable the test on MacOS 10.4,
> right? Does it no longer fail there?

10.4 (Tiger) is not supported any more on trunk.
Av1, with comment 2 suggestion(s).

(In reply to comment #2)

> Please don't change these var to let as long as the rest of the file uses var.

My fault: I somehow thought there were already some 'let' in this file.

> So the only actual change in this patch is to reenable the test on MacOS 10.4,
> right?

No actual behavior changes: just 2 dead code removals.
Attachment #439747 - Attachment is obsolete: true
Attachment #439817 - Flags: review?(cbiesinger)
Attachment #439817 - Flags: review?(cbiesinger) → review+
Comment on attachment 439817 [details] [diff] [review]
(Av2) Remove a useless createInstance(), Whitespace cleanup, Remove MacOSX 10.4 workaround (on m-c)
[Checkin: Comment 5]


http://hg.mozilla.org/mozilla-central/rev/95310a8ac765
Attachment #439817 - Attachment description: (Av2) Remove a useless createInstance(), Whitespace cleanup, Remove MacOSX 10.4 workaround (on m-c) → (Av2) Remove a useless createInstance(), Whitespace cleanup, Remove MacOSX 10.4 workaround (on m-c) [Checkin: Comment 5]
Resolving as fixed based on Comment 5...
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.