WinCE gfx cairo _cairo_win32_tmpfile does not compile

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: wolfe, Assigned: dougt)

Tracking

({mobile})

Trunk
ARM
Windows Mobile 6 Professional
mobile
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

9 years ago
Created attachment 340018 [details] [diff] [review]
WinCE replace body of function _cairo_win32_tmpfile with call to tmpfile()

There is no _open_osfhandle function available in WinCE - but there is a CRT function to return a FILE * to a temporary file - tmpfile()
Attachment #340018 - Flags: review?(pavlov)

Updated

9 years ago
Assignee: nobody → wolfe
(Reporter)

Comment 1

9 years ago
Created attachment 340047 [details] [diff] [review]
Duplicated _cairo_win32_tmpfile() functions - missed one on the first pass

I got the _cairo_win32_tmpfile() function inside cairo-win32.c, but missed the identical function inside cairo-misc.c

This updated patch does the identical change to the two identical source code functions.
Attachment #340018 - Attachment is obsolete: true
Attachment #340047 - Flags: review?(pavlov)
Attachment #340018 - Flags: review?(pavlov)

Updated

9 years ago
Attachment #340047 - Flags: review?(pavlov) → review?(vladimir)

Comment 2

9 years ago
Comment on attachment 340047 [details] [diff] [review]
Duplicated _cairo_win32_tmpfile() functions - missed one on the first pass

please add this patch to gfx/cairo/ and update the README with the patch so it can be pushed upstream
Could the existing cairo code be replaced with tmpfile() on Windows altogether? Without the need to special case WINCE?

Comment 4

9 years ago
we can't -- see the comment at the top of _cairo_win32_tmpfile()
(Assignee)

Comment 5

9 years ago
Created attachment 340436 [details] [diff] [review]
patch v.1
Assignee: wolfe → doug.turner
Attachment #340047 - Attachment is obsolete: true
Attachment #340436 - Flags: review?
Attachment #340047 - Flags: review?(vladimir)
(Assignee)

Updated

9 years ago
Attachment #340436 - Attachment is patch: true
Attachment #340436 - Attachment mime type: application/octet-stream → text/plain
Attachment #340436 - Flags: review? → review?(vladimir)
Comment on attachment 340436 [details] [diff] [review]
patch v.1

Looks fine, but can you just delete the duplicate function in cairo-win32.c?  No reason for it to be there, was just an omission in not removing it when it got moved to -misc.c
Attachment #340436 - Flags: review?(vladimir) → review+
(Assignee)

Comment 7

9 years ago
Created attachment 340450 [details] [diff] [review]
patch v.2

after talking to vlad, this patch removes the cairo-win32.c file from the Makefile.  This change needs to be reflected upstream.
Attachment #340436 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Attachment #340450 - Flags: review?(vladimir)
Attachment #340450 - Flags: review?(vladimir) → review+
(Assignee)

Comment 8

9 years ago
be1ce0c38423	Doug Turner — Bug 456644 - WinCE gfx cairo _cairo_win32_tmpfile does not compile. r=vlad

thanks vlad.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Component: General → GFX: Thebes
Product: Fennec → Core
QA Contact: general → thebes
You need to log in before you can comment on or make changes to this bug.