456644 - WinCE gfx cairo _cairo_win32_tmpfile does not compile

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[John Wolfe (:wolfe)]

Attachment: WinCE replace body of function _cairo_win32_tmpfile with call to tmpfile()

There is no _open_osfhandle function available in WinCE - but there is a CRT function to return a FILE * to a temporary file - tmpfile()

Comment 1

[John Wolfe (:wolfe)]

Attachment: Duplicated _cairo_win32_tmpfile() functions - missed one on the first pass

I got the _cairo_win32_tmpfile() function inside cairo-win32.c, but missed the identical function inside cairo-misc.c

This updated patch does the identical change to the two identical source code functions.

Comment 2

[Stuart Parmenter]

Comment on attachment 340047 [details] [diff] [review]
Duplicated _cairo_win32_tmpfile() functions - missed one on the first pass

please add this patch to gfx/cairo/ and update the README with the patch so it can be pushed upstream

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Could the existing cairo code be replaced with tmpfile() on Windows altogether? Without the need to special case WINCE?

Comment 4

[Stuart Parmenter]

we can't -- see the comment at the top of _cairo_win32_tmpfile()

Comment 5

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 340436 [details] [diff] [review]
patch v.1

Looks fine, but can you just delete the duplicate function in cairo-win32.c?  No reason for it to be there, was just an omission in not removing it when it got moved to -misc.c

Comment 7

[Doug Turner (:dougt)]

Attachment: patch v.2

after talking to vlad, this patch removes the cairo-win32.c file from the Makefile.  This change needs to be reflected upstream.

Comment 8

[Doug Turner (:dougt)]

be1ce0c38423	Doug Turner — Bug 456644 - WinCE gfx cairo _cairo_win32_tmpfile does not compile. r=vlad

thanks vlad.