456713 - Date format always month/day in header of week and multiweek views

Status: RESOLVED FIXED

(Mozilla Localizations :: en-GB / English (United Kingdom), defect)

Description

[Trevor Morgan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: 0.9 build 2008091719

The date range shown in week and multiweek views is month-day instead of locale setting.  Day view is correct.

Reproducible: Always

Steps to Reproduce:
Switch to week or multiweek view
Actual Results:  
Date range shown as "September 15 - October 26, 2008"

Expected Results:  
For my locale (UK) should be "15 September - 26 October 2008"

Comment 1

[Trevor Morgan]

Also applies to tooltips of multi-day all-day events

Comment 2

[Martin Schröder [:mschroeder]]

This inconsistency is still visible using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090429 Lightning/1.0pre (20090429) Shredder/3.0b3pre. But I couldn't reproduce the issue for tooltips.

Comment 3

[Trevor Morgan]

Tooltips display correctly on single day events and on multi-day events with start and end times.
Multi-day events show as e.g.: "August 1-2, 2009"
instead of "1-2 August 2009"

Also related: all day events (single or multi-day) do not respect the short/long date format in lightning options.  Events with start & end times are okay.

Using:
Lightning version 0.9 build 2008091719
Thunderbird version 2.0.0.21 (20090302)

Comment 4

[Trevor Morgan]

Still apparent using Lightning 1.0b1

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.5) 
Gecko/20091204 
Lightning/1.0b1 
Thunderbird/3.0

Comment 5

[Decathlon]

To fix this issue (at least for the description interval in the views header) the order of some elements for three strings inside calendar.properties (locale file) should be changed.
If a locale needs the month day before the month name, the following strings [1] (related to week and multi-week view):

dayIntervalInMonth = %1$S %2$S – %3$S, %4$S
dayIntervalBetweenMonths = %1$S %2$S – %3$S %4$S, %5$S
dayIntervalBetweenYears = %1$S %2$S, %3$S – %4$S %5$S, %6$S

should become:

dayIntervalInMonth=%2$S – %3$S %1$S, %4$S  
dayIntervalBetweenMonths=%2$S %1$S – %4$S %3$S, %5$S
dayIntervalBetweenYears=%2$S %1$S, %3$S – %5$S %4$S, %6$S

Is it a problem that should be solved by the localizers (that have to change the order of the elements inside the mentioned strings) or should it be solved by adding some controls or furthers strings that allow to change the order? I mean something like "monthlyOrder" or "yearlyOrder" inside calendar-event-dialog.properties files (that localizers should change for the own locale anyway).

[1]
http://mxr.mozilla.org/comm-central/source/calendar/locales/en-US/chrome/calendar/calendar.properties#510

Comment 6

[石庭豐 (Seak, Teng-Fong)]

Not only the month/day order is not respected, the string is not localized: it's always written in English.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Its possible that the string is taken from the OS, could you check what language you have set there?

Comment 8

[Trevor Morgan]

(In reply to Decathlon from comment #5)
> dayIntervalInMonth=%2$S – %3$S %1$S, %4$S  
> dayIntervalBetweenMonths=%2$S %1$S – %4$S %3$S, %5$S
> dayIntervalBetweenYears=%2$S %1$S, %3$S – %5$S %4$S, %6$S

Confirmed that this is the case by changing my installation, but I don't know how to check it in.
Hence move to Localisations

Comment 9

[Ian Neal]

(In reply to Trevor Morgan from comment #8)
> (In reply to Decathlon from comment #5)
> > dayIntervalInMonth=%2$S – %3$S %1$S, %4$S  
> > dayIntervalBetweenMonths=%2$S %1$S – %4$S %3$S, %5$S
> > dayIntervalBetweenYears=%2$S %1$S, %3$S – %5$S %4$S, %6$S
> 
> Confirmed that this is the case by changing my installation, but I don't
> know how to check it in.
> Hence move to Localisations

Do we actually need the commas for en-GB? I would say not.

Comment 10

[Ian Neal]

(In reply to Ian Neal from comment #9)
> (In reply to Trevor Morgan from comment #8)
> > (In reply to Decathlon from comment #5)
> > > dayIntervalInMonth=%2$S – %3$S %1$S, %4$S  
> > > dayIntervalBetweenMonths=%2$S %1$S – %4$S %3$S, %5$S
> > > dayIntervalBetweenYears=%2$S %1$S, %3$S – %5$S %4$S, %6$S
> > 
> > Confirmed that this is the case by changing my installation, but I don't
> > know how to check it in.
> > Hence move to Localisations
> 
> Do we actually need the commas for en-GB? I would say not.

Thinking a bit more about it, I would say definitely not for dayIntervalBetweenYears, the other two might still be better with commas.

Comment 11

[Trevor Morgan]

Actually I would say no commas in any.  I quoted Comment 5 without checking.

Comment 12

[Ian Neal]

Attachment: Correct date format for en-GB [Checked in: Comment 15]

Comment 13

[Ian Neal]

Comment on attachment 625111 [details] [diff] [review]
Correct date format for en-GB [Checked in: Comment 15]

Hopefully this is correct.

Comment 14

[Trevor Morgan]

Comment on attachment 625111 [details] [diff] [review]
Correct date format for en-GB [Checked in: Comment 15]

Looks okay to me.

Comment 15

[Ian Neal]

Comment on attachment 625111 [details] [diff] [review]
Correct date format for en-GB [Checked in: Comment 15]

http://hg.mozilla.org/releases/l10n/mozilla-beta/en-GB/rev/c51a9ccf3dec
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/aed04b5427b1

Comment 16

[石庭豐 (Seak, Teng-Fong)]

(In reply to Philipp Kewisch [:Fallen] (away until May 28th) from comment #7)
> Its possible that the string is taken from the OS, could you check what
> language you have set there?

After reading the other comments after yours, I came to realize that those strings come from Lightning instead of O/S.  And IMO, this approach leads to a lot of l10n problem and this bug is not yet fixed for me.  I'll upload two images to explain the problems.

Comment 17

[石庭豐 (Seak, Teng-Fong)]

Attachment: Mix-up of language

At the top of this image, you could the settings on the left:
in this computer, everything is in English EXCEPT regional settings which is in French.  And the "string" is only in French in "Day" mode.  The other modes show English "strings" while, IMO, they should be in French.

(Partial off-topic)
By the way, when I switch Lightning to French interface so that the other modes show French strings, the strings are not totally correct:
1. Month names in French are not capitalized, ie we have "mai" instead of "Mai" for the month of May, "juin" instead of "Juin" for June, etc, etc
2. Month abbreviations for June and July are "juin" and "juil" instead of "jun" and "jul"

Comment 18

[石庭豐 (Seak, Teng-Fong)]

Attachment: UK and US date format mix-up

In this example, everything is in English but the strings are in two formats:
* UK -- D M Y format
* US -- M D Y format

Comment 19

[石庭豐 (Seak, Teng-Fong)]

So, is it possible to get every string from O/S (& regional settings) in order to have a consistent view?