Closed Bug 456912 Opened 15 years ago Closed 14 years ago

crash [@ nsDocShell::GetSessionStorageForURI]

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: zeniko, Unassigned)

References

()

Details

(Keywords: crash)

Crash Data

Steps to Reproduce:
1. Evaluate the following JavaScript code in the Error Console:

> Application.activeWindow.tabs[0]._browser.docShell.getSessionStorageForURI(null)

Crash data:
0384c4b0-8a5b-11dd-815b-0013211cbf8a
a288ecd9-8a9e-11dd-89e3-001cc4e2bf68
9b494640-8a9e-11dd-b226-0013211cbf8a

Affects at least Firefox 3.0.1 and the latest Trunk nightlies.
Flags: wanted1.9.0.x?
Flags: blocking1.9.1?
aURI is supposed to be non-null at this point, even though XPCOM allows to pass null pointers...
Severity: major → critical
Already fixed here:
https://bugzilla.mozilla.org/attachment.cgi?id=339854&action=diff#a/docshell/base/nsDocShell.cpp_sec2

Patch waits for review, not sure how the bug is prioritized, IMO should go as P1 or 2 in hand with localStorage implementation to Fx3.1b1.
Depends on: 455070
Flags: wanted1.9.0.x? → wanted1.9.0.x+
Version: unspecified → Trunk
Not blocking as this can't be triggered by content code. Bug 455070 comment #10 is also relevant here.
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
This can easily be fixed with just adding a non-null check. The patch from bug 455070 doesn't do anything smarter.
This was FIXED by bug 458091.
Status: NEW → RESOLVED
Closed: 14 years ago
No longer depends on: 455070
Resolution: --- → FIXED
Crash Signature: [@ nsDocShell::GetSessionStorageForURI]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.