457001 - Main feature title cut on Basque what's new page

Status: RESOLVED WORKSFORME

(www.mozilla.org :: General, defect)

Description

[Julen Ruiz Aizpuru]

Attachment: Screenshot of the issue

I haven't realized of this until the upgrade to 3.0.2 but the main title of the Basque what's new page isn't displayed correctly.

If you see the source code, the JavaScript snippet shows the whole sentence in two variables:
  var userversion = '3.0.2 erabiltzen ari zara';
  var message1 = 'Une honetan Firefox ';
But only "Une honetan Firefox 3.0.2" is shown. I don't know if this is because the sentence is too long or if userversion can't contain letters.
We could reword it and make it shorter to be "Firefox 3.0.2 erabiltzen ari zara" but the order can't be altered, otherwise the sentence has no sense in Basque (so we can't put Firefox 3.0.2 at the end).

Comment 1

[Pascal Chevrel:pascalc]

I am not sure what the correct behaviour should be and if userversion is still actually used, CCing Wil and Steven for advice

Comment 2

[Wil Clouser [:clouserw]]

userversion is still used and it should only be a version number.  The actual line in the file should be:
  var userversion = '<?=LATEST_FIREFOX_VERSION?>';

It's used to notify the user of an outdated version.  If their firefox version isn't equal to userversion the messages about upgrading will appear on the screen.

Unfortunately it is hardcoded to be appended to the message right now.  If there is no way to make a reasonable sentence in Basque in that format we'll have to make a better function (which we should have done in the first place).

Comment 3

[Julen Ruiz Aizpuru]

Yes, in this case the verb must go after Firefox version number so it would be great to fix this.

Comment 4

[Wil Clouser [:clouserw]]

Attachment: add sprintf

This should fix us up.  The patch is huge but the changes to the .js files are short and the important part.  The rest is just converting to use the new format and is the same on all the pages.

Comment 5

[Reed Loden [:reed]]

Comment on attachment 340516 [details] [diff] [review]
add sprintf

We should be swapping all the locales over to the new PHP-based code I added for en-US and en-GB rather than continuing to support this old and very broken JS code. I just haven't had the time to do this myself, so if you have some time to do it, it would be much appreciated. Otherwise, I'll try to get to it when I can.

Comment 6

[Alex Buchanan [:abuchanan]]

Looks like this page has been replaced and this problem no longer exists.